Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Molenda <jason-swarelist@molenda.com>
To: Frederic RISS <frederic.riss@st.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [RFC] Don't loose compilation directory in Dwarf2 line-tables
Date: Thu, 13 Apr 2006 19:58:00 -0000	[thread overview]
Message-ID: <20060413125845.A98448@molenda.com> (raw)
In-Reply-To: <1144927446.14807.561.camel@crx549.cro.st.com>; from frederic.riss@st.com on Thu, Apr 13, 2006 at 01:24:06PM +0200

Frederic,

For what it's worth, I fixed the same bug yesterday.  Our changes
are similar - in dwarf2_start_subfile I used this code at the end
of the function:

  /* APPLE LOCAL: If FILENAME isn't an absolute path and DIRNAME is either
     NULL or a relative path, prepend COMP_DIR on there to get an absolute
     path.  */

  if (!IS_ABSOLUTE_PATH (filename) && dirname == NULL)
    dirname = comp_dir;
  else 
    if (!IS_ABSOLUTE_PATH (filename) && !IS_ABSOLUTE_PATH (dirname))
      {
        dirname = concat (comp_dir, SLASH_STRING, dirname, (char *) NULL);
        make_cleanup (xfree, dirname);
      }
  start_subfile (filename, dirname);
  do_cleanups (clean);


(with 'cleanup' initialized to a null_cleanup at the top of the file,
naturally.)

J


      parent reply	other threads:[~2006-04-13 19:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-13 11:25 Frederic RISS
2006-04-13 17:49 ` Jim Blandy
2006-04-14  7:32   ` [RFC] Don't lose " Frederic RISS
2006-04-14  7:41     ` Jim Blandy
2006-04-14  8:23       ` Frederic RISS
2006-04-14 14:04         ` Daniel Jacobowitz
2006-04-14 14:51           ` Frederic RISS
2006-04-18 12:32             ` Frederic RISS
2006-04-18 13:04               ` Daniel Jacobowitz
2006-04-18 14:00                 ` Frederic RISS
2006-04-20 16:27                   ` Daniel Jacobowitz
2006-04-21  7:14                     ` Frederic RISS
2006-04-21  1:10                   ` Jim Blandy
2006-04-21  8:35                     ` Frederic RISS
2006-04-21 16:46                       ` Jim Blandy
2006-04-21 17:00                         ` Frederic RISS
2006-04-24 12:49                         ` Andrew STUBBS
2006-04-14  8:44     ` Eli Zaretskii
2006-04-14 11:44       ` Frederic RISS
2006-04-14 13:08         ` Eli Zaretskii
2006-04-14 13:42           ` Frederic RISS
2006-04-14 14:21             ` Eli Zaretskii
2006-04-14 14:58               ` Daniel Jacobowitz
2006-04-14 15:03                 ` Eli Zaretskii
2006-04-14 18:39               ` Frédéric Riss
2006-04-13 19:58 ` Jason Molenda [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060413125845.A98448@molenda.com \
    --to=jason-swarelist@molenda.com \
    --cc=frederic.riss@st.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox