From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9684 invoked by alias); 14 Apr 2006 08:44:50 -0000 Received: (qmail 9676 invoked by uid 22791); 14 Apr 2006 08:44:50 -0000 X-Spam-Check-By: sourceware.org Received: from romy.inter.net.il (HELO romy.inter.net.il) (192.114.186.66) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Apr 2006 08:44:48 +0000 Received: from HOME-C4E4A596F7 (IGLD-80-230-89-169.inter.net.il [80.230.89.169]) by romy.inter.net.il (MOS 3.7.3-GA) with ESMTP id DZC51154 (AUTH halo1); Fri, 14 Apr 2006 11:44:44 +0300 (IDT) Date: Fri, 14 Apr 2006 08:44:00 -0000 Message-Id: From: Eli Zaretskii To: Frederic RISS CC: jimb@red-bean.com, gdb-patches@sourceware.org In-reply-to: <1144999942.14807.721.camel@crx549.cro.st.com> (message from Frederic RISS on Fri, 14 Apr 2006 09:32:22 +0200) Subject: Re: [RFC] Don't lose compilation directory in Dwarf2 line-tables Reply-to: Eli Zaretskii References: <1144927446.14807.561.camel@crx549.cro.st.com> <8f2776cb0604131049i69e9b20fv78e60c023f245e56@mail.gmail.com> <1144999942.14807.721.camel@crx549.cro.st.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-04/txt/msg00185.txt.bz2 > From: Frederic RISS > Cc: GDB Patches > Date: Fri, 14 Apr 2006 09:32:22 +0200 > > On Thu, 2006-04-13 at 10:49 -0700, Jim Blandy wrote: > > Hi, Frederic. Thanks for the patch! I think you're right about how > > GDB should interpret DW_AT_comp_dir and directories in the line number > > information. Some comments: > > Great. > > > You should generally include a ChangeLog entry along with the patch; > > you'll have to write it anyway, and it helps reviewers get oriented > > for what they're going to see in the patch itself. > > Will do for the next round. Thanks. In addition, I think the current algorithm for searching the sources is described in the user's manual; please see if there's something in that description that needs to be updated with your changes.