From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: PATCH: use frame_unwind_register instead of frame_register
Date: Mon, 06 Nov 2006 20:06:00 -0000 [thread overview]
Message-ID: <m3wt68nxvt.fsf@codesourcery.com> (raw)
In-Reply-To: <20061106143307.GA31556@nevyn.them.org> (Daniel Jacobowitz's message of "Mon, 6 Nov 2006 09:33:07 -0500")
Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Nov 03, 2006 at 02:11:17PM -0800, Jim Blandy wrote:
>>
>> Committed as obvious --- frame_unwind_register takes care of passing
>> all the dummy arguments to frame_register, so dwarf_expr_read_reg
>> shouldn't have to bother.
>>
>> gdb/ChangeLog:
>> 2006-11-03 Jim Blandy <jimb@codesourcery.com>
>>
>> * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register
>> instead of frame_register. Doc fix.
>
> Jim, in addition to leaving a pile of unused variables in the function
> (see my other message from Friday), you've introduced an
> off-by-one-frame error here. frame_register unwinds from the NEXT
> frame, but frame_unwind_register unwinds from THIS frame. Our GDB
> autotester reported about six hundred new failures and I'm pretty sure
> that's why; we now use the previous frame's r11 for fbreg. Could you
> revert or fix this, please?
Urf. I feel like a bull in a china shop. Testing revised patch
now...
next prev parent reply other threads:[~2006-11-06 20:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 22:11 Jim Blandy
2006-11-03 22:23 ` Daniel Jacobowitz
2006-11-06 14:33 ` Daniel Jacobowitz
2006-11-06 20:06 ` Jim Blandy [this message]
2006-11-06 23:24 ` Jim Blandy
2006-11-06 23:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3wt68nxvt.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox