From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: Re: PATCH: use frame_unwind_register instead of frame_register
Date: Mon, 06 Nov 2006 23:24:00 -0000 [thread overview]
Message-ID: <m3odrknoq6.fsf@codesourcery.com> (raw)
In-Reply-To: <20061106143307.GA31556@nevyn.them.org> (Daniel Jacobowitz's message of "Mon, 6 Nov 2006 09:33:07 -0500")
I've committed the below, which 1) uses frame_register_read instead of
frame_unwind_register, thereby obtaining the registers from the right
frame, and 2) removes the now-unused variables.
2006-11-06 Jim Blandy <jimb@codesourcery.com>
* (dwarf_expr_read_reg): Use frame_register_read, not frame_register.
* dwarf2loc.c (dwarf_expr_read_reg): Use frame_register_read
instead of frame_register. Doc fix.
Index: gdb/dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.35
diff -u -r1.35 dwarf2loc.c
--- gdb/dwarf2loc.c 3 Nov 2006 22:09:28 -0000 1.35
+++ gdb/dwarf2loc.c 6 Nov 2006 23:19:48 -0000
@@ -120,16 +120,15 @@
dwarf_expr_read_reg (void *baton, int dwarf_regnum)
{
struct dwarf_expr_baton *debaton = (struct dwarf_expr_baton *) baton;
- CORE_ADDR result, save_addr;
- enum lval_type lval_type;
+ CORE_ADDR result;
gdb_byte *buf;
- int optimized, regnum, realnum, regsize;
+ int regnum, regsize;
regnum = DWARF2_REG_TO_REGNUM (dwarf_regnum);
regsize = register_size (current_gdbarch, regnum);
buf = alloca (regsize);
- frame_unwind_register (debaton->frame, regnum, buf);
+ frame_register_read (debaton->frame, regnum, buf);
/* NOTE: cagney/2003-05-22: This extract is assuming that a DWARF 2
address is always unsigned. That may or may not be true. */
result = extract_unsigned_integer (buf, regsize);
next prev parent reply other threads:[~2006-11-06 23:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-03 22:11 Jim Blandy
2006-11-03 22:23 ` Daniel Jacobowitz
2006-11-06 14:33 ` Daniel Jacobowitz
2006-11-06 20:06 ` Jim Blandy
2006-11-06 23:24 ` Jim Blandy [this message]
2006-11-06 23:27 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3odrknoq6.fsf@codesourcery.com \
--to=jimb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox