From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7572 invoked by alias); 6 Nov 2006 23:24:01 -0000 Received: (qmail 7563 invoked by uid 22791); 6 Nov 2006 23:24:00 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Nov 2006 23:23:56 +0000 Received: (qmail 5933 invoked from network); 6 Nov 2006 23:23:54 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 6 Nov 2006 23:23:54 -0000 To: gdb-patches@sourceware.org Subject: Re: PATCH: use frame_unwind_register instead of frame_register References: <20061106143307.GA31556@nevyn.them.org> From: Jim Blandy Date: Mon, 06 Nov 2006 23:24:00 -0000 In-Reply-To: <20061106143307.GA31556@nevyn.them.org> (Daniel Jacobowitz's message of "Mon, 6 Nov 2006 09:33:07 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00031.txt.bz2 I've committed the below, which 1) uses frame_register_read instead of frame_unwind_register, thereby obtaining the registers from the right frame, and 2) removes the now-unused variables. 2006-11-06 Jim Blandy * (dwarf_expr_read_reg): Use frame_register_read, not frame_register. * dwarf2loc.c (dwarf_expr_read_reg): Use frame_register_read instead of frame_register. Doc fix. Index: gdb/dwarf2loc.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.35 diff -u -r1.35 dwarf2loc.c --- gdb/dwarf2loc.c 3 Nov 2006 22:09:28 -0000 1.35 +++ gdb/dwarf2loc.c 6 Nov 2006 23:19:48 -0000 @@ -120,16 +120,15 @@ dwarf_expr_read_reg (void *baton, int dwarf_regnum) { struct dwarf_expr_baton *debaton = (struct dwarf_expr_baton *) baton; - CORE_ADDR result, save_addr; - enum lval_type lval_type; + CORE_ADDR result; gdb_byte *buf; - int optimized, regnum, realnum, regsize; + int regnum, regsize; regnum = DWARF2_REG_TO_REGNUM (dwarf_regnum); regsize = register_size (current_gdbarch, regnum); buf = alloca (regsize); - frame_unwind_register (debaton->frame, regnum, buf); + frame_register_read (debaton->frame, regnum, buf); /* NOTE: cagney/2003-05-22: This extract is assuming that a DWARF 2 address is always unsigned. That may or may not be true. */ result = extract_unsigned_integer (buf, regsize);