Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: gdb-patches@sourceware.org
Subject: PATCH: use frame_unwind_register instead of frame_register
Date: Fri, 03 Nov 2006 22:11:00 -0000	[thread overview]
Message-ID: <m3fyd0nptm.fsf@codesourcery.com> (raw)


Committed as obvious --- frame_unwind_register takes care of passing
all the dummy arguments to frame_register, so dwarf_expr_read_reg
shouldn't have to bother.

gdb/ChangeLog:
2006-11-03  Jim Blandy  <jimb@codesourcery.com>

        * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register
        instead of frame_register.  Doc fix.

Index: gdb/dwarf2loc.c
===================================================================
RCS file: /cvs/src/src/gdb/dwarf2loc.c,v
retrieving revision 1.34
diff -u -r1.34 dwarf2loc.c
--- gdb/dwarf2loc.c	10 Oct 2006 03:17:53 -0000	1.34
+++ gdb/dwarf2loc.c	3 Nov 2006 21:52:38 -0000
@@ -114,9 +114,8 @@
 
 /* Helper functions for dwarf2_evaluate_loc_desc.  */
 
-/* Using the frame specified in BATON, read register REGNUM.  The lval
-   type will be returned in LVALP, and for lval_memory the register
-   save address will be returned in ADDRP.  */
+/* Using the frame specified in BATON, return the value of register
+   REGNUM, treated as an unsigned integer.  */
 static CORE_ADDR
 dwarf_expr_read_reg (void *baton, int dwarf_regnum)
 {
@@ -130,8 +129,7 @@
   regsize = register_size (current_gdbarch, regnum);
   buf = alloca (regsize);
 
-  frame_register (debaton->frame, regnum, &optimized, &lval_type, &save_addr,
-		  &realnum, buf);
+  frame_unwind_register (debaton->frame, regnum, buf);
   /* NOTE: cagney/2003-05-22: This extract is assuming that a DWARF 2
      address is always unsigned.  That may or may not be true.  */
   result = extract_unsigned_integer (buf, regsize);


             reply	other threads:[~2006-11-03 22:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-03 22:11 Jim Blandy [this message]
2006-11-03 22:23 ` Daniel Jacobowitz
2006-11-06 14:33 ` Daniel Jacobowitz
2006-11-06 20:06   ` Jim Blandy
2006-11-06 23:24   ` Jim Blandy
2006-11-06 23:27     ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3fyd0nptm.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox