From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24634 invoked by alias); 3 Nov 2006 22:11:19 -0000 Received: (qmail 24626 invoked by uid 22791); 3 Nov 2006 22:11:19 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 03 Nov 2006 22:11:16 +0000 Received: (qmail 8919 invoked from network); 3 Nov 2006 22:11:15 -0000 Received: from unknown (HELO localhost) (jimb@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Nov 2006 22:11:15 -0000 To: gdb-patches@sourceware.org Subject: PATCH: use frame_unwind_register instead of frame_register From: Jim Blandy Date: Fri, 03 Nov 2006 22:11:00 -0000 Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00022.txt.bz2 Committed as obvious --- frame_unwind_register takes care of passing all the dummy arguments to frame_register, so dwarf_expr_read_reg shouldn't have to bother. gdb/ChangeLog: 2006-11-03 Jim Blandy * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register instead of frame_register. Doc fix. Index: gdb/dwarf2loc.c =================================================================== RCS file: /cvs/src/src/gdb/dwarf2loc.c,v retrieving revision 1.34 diff -u -r1.34 dwarf2loc.c --- gdb/dwarf2loc.c 10 Oct 2006 03:17:53 -0000 1.34 +++ gdb/dwarf2loc.c 3 Nov 2006 21:52:38 -0000 @@ -114,9 +114,8 @@ /* Helper functions for dwarf2_evaluate_loc_desc. */ -/* Using the frame specified in BATON, read register REGNUM. The lval - type will be returned in LVALP, and for lval_memory the register - save address will be returned in ADDRP. */ +/* Using the frame specified in BATON, return the value of register + REGNUM, treated as an unsigned integer. */ static CORE_ADDR dwarf_expr_read_reg (void *baton, int dwarf_regnum) { @@ -130,8 +129,7 @@ regsize = register_size (current_gdbarch, regnum); buf = alloca (regsize); - frame_register (debaton->frame, regnum, &optimized, &lval_type, &save_addr, - &realnum, buf); + frame_unwind_register (debaton->frame, regnum, buf); /* NOTE: cagney/2003-05-22: This extract is assuming that a DWARF 2 address is always unsigned. That may or may not be true. */ result = extract_unsigned_integer (buf, regsize);