Re: PATCH: use frame_unwind_register instead of frame_register

Daniel Jacobowitz
2006-11-06T14:33:17Z

On Fri, Nov 03, 2006 at 02:11:17PM -0800, Jim Blandy wrote:
>
> Committed as obvious --- frame_unwind_register takes care of passing
> all the dummy arguments to frame_register, so dwarf_expr_read_reg
> shouldn't have to bother.
>
> gdb/ChangeLog:
> 2006-11-03 Jim Blandy <jimb@codesourcery.com>
>
> * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register
> instead of frame_register. Doc fix.

Jim, in addition to leaving a pile of unused variables in the function
(see my other message from Friday), you've introduced an
off-by-one-frame error here. frame_register unwinds from the NEXT
frame, but frame_unwind_register unwinds from THIS frame. Our GDB
autotester reported about six hundred new failures and I'm pretty sure
that's why; we now use the previous frame's r11 for fbreg. Could you
revert or fix this, please?