From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-46025-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 22620 invoked by alias); 6 Nov 2006 20:06:14 -0000
Received: (qmail 22602 invoked by uid 22791); 6 Nov 2006 20:06:13 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 06 Nov 2006 20:06:09 +0000
Received: (qmail 19374 invoked from network); 6 Nov 2006 20:06:08 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 6 Nov 2006 20:06:08 -0000
To: gdb-patches@sourceware.org
Subject: Re: PATCH: use frame_unwind_register instead of frame_register
References: <m3fyd0nptm.fsf@codesourcery.com> 	<20061106143307.GA31556@nevyn.them.org>
From: Jim Blandy <jimb@codesourcery.com>
Date: Mon, 06 Nov 2006 20:06:00 -0000
In-Reply-To: <20061106143307.GA31556@nevyn.them.org> (Daniel Jacobowitz's message of "Mon, 6 Nov 2006 09:33:07 -0500")
Message-ID: <m3wt68nxvt.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2006-11/txt/msg00029.txt.bz2


Daniel Jacobowitz <drow@false.org> writes:
> On Fri, Nov 03, 2006 at 02:11:17PM -0800, Jim Blandy wrote:
>> 
>> Committed as obvious --- frame_unwind_register takes care of passing
>> all the dummy arguments to frame_register, so dwarf_expr_read_reg
>> shouldn't have to bother.
>> 
>> gdb/ChangeLog:
>> 2006-11-03  Jim Blandy  <jimb@codesourcery.com>
>> 
>>         * dwarf2loc.c (dwarf_expr_read_reg): Use frame_unwind_register
>>         instead of frame_register.  Doc fix.
>
> Jim, in addition to leaving a pile of unused variables in the function
> (see my other message from Friday), you've introduced an
> off-by-one-frame error here.  frame_register unwinds from the NEXT
> frame, but frame_unwind_register unwinds from THIS frame.  Our GDB
> autotester reported about six hundred new failures and I'm pretty sure
> that's why; we now use the previous frame's r11 for fbreg.  Could you
> revert or fix this, please?

Urf.  I feel like a bull in a china shop.  Testing revised patch
now...