Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c
Date: Mon, 25 Apr 2011 17:04:00 -0000	[thread overview]
Message-ID: <m3wriiuutu.fsf@fleche.redhat.com> (raw)
In-Reply-To: <4D612DC6.5010805@codesourcery.com> (Yao Qi's message of "Sun, 20	Feb 2011 23:05:42 +0800")

>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Yao> All the comments in previous mails are address in this new patch,
Yao> 1.  rename 'linux-common.h' to 'linux-ptrace.h', which includes only
Yao> ptrace-related macros.
Yao> 2.  include <sys/wait.h> in linux-ptrace.h for macro __WALL,
Yao> 3.  add dependency tracking for gdbserver,

Yao> Ping.

Yao> Ping?

Yao> Ping.  7.3 branch was created.  OK for trunk?

Thanks for persevering.

I re-read the previous threads on this.  My understanding is that Mark
is uncertain about the general direction of this, but that neither he
nor anybody else objects to this specific patch.

I read the patch and I think merging common macro definitions makes
sense.

So, this is ok.

Tom


  parent reply	other threads:[~2011-04-25 17:04 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  8:24 Yao Qi
2011-02-18  9:36 ` Jan Kratochvil
2011-02-18 14:54   ` Yao Qi
2011-02-18 15:14     ` Mark Kettenis
2011-02-18 16:14   ` Pedro Alves
2011-02-18 15:24 ` Tom Tromey
2011-02-18 15:46   ` Yao Qi
2011-02-18 15:55     ` Tom Tromey
2011-02-18 15:52 ` Pedro Alves
2011-02-18 17:21   ` Yao Qi
2011-02-20 21:34     ` Yao Qi
2011-02-28 12:38       ` Ping: " Yao Qi
2011-02-28 14:35         ` question about the common/ subdir (was "Re: Ping: Merge duplicated macros in linux-nat.c and linux-low.c") Joel Brobecker
2011-02-28 14:54           ` Yao Qi
2011-02-28 15:11             ` Pedro Alves
2011-02-28 15:00           ` Pedro Alves
2011-03-11  5:05         ` Ping: Merge duplicated macros in linux-nat.c and linux-low.c Yao Qi
2011-03-29  7:46           ` Yao Qi
2011-04-07 14:06           ` Yao Qi
2011-04-25 17:04       ` Tom Tromey [this message]
2011-04-26 15:39         ` [common] " Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3wriiuutu.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox