From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31717 invoked by alias); 25 Apr 2011 17:04:06 -0000 Received: (qmail 31708 invoked by uid 22791); 25 Apr 2011 17:04:05 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 25 Apr 2011 17:03:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3PH3hsb015632 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 25 Apr 2011 13:03:43 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p3PH3gje000581; Mon, 25 Apr 2011 13:03:43 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p3PH3gnH017632; Mon, 25 Apr 2011 13:03:42 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id DC5363781C7; Mon, 25 Apr 2011 11:03:41 -0600 (MDT) From: Tom Tromey To: Yao Qi Cc: gdb-patches@sourceware.org Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c References: <4D5E2021.2070107@codesourcery.com> <201102181546.26744.pedro@codesourcery.com> <4D5EA533.608@codesourcery.com> <4D612DC6.5010805@codesourcery.com> Date: Mon, 25 Apr 2011 17:04:00 -0000 In-Reply-To: <4D612DC6.5010805@codesourcery.com> (Yao Qi's message of "Sun, 20 Feb 2011 23:05:42 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-04/txt/msg00445.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> All the comments in previous mails are address in this new patch, Yao> 1. rename 'linux-common.h' to 'linux-ptrace.h', which includes only Yao> ptrace-related macros. Yao> 2. include in linux-ptrace.h for macro __WALL, Yao> 3. add dependency tracking for gdbserver, Yao> Ping. Yao> Ping? Yao> Ping. 7.3 branch was created. OK for trunk? Thanks for persevering. I re-read the previous threads on this. My understanding is that Mark is uncertain about the general direction of this, but that neither he nor anybody else objects to this specific patch. I read the patch and I think merging common macro definitions makes sense. So, this is ok. Tom