From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: Joel Brobecker <brobecker@adacore.com>
Subject: Re: question about the common/ subdir (was "Re: Ping: Merge duplicated macros in linux-nat.c and linux-low.c")
Date: Mon, 28 Feb 2011 15:00:00 -0000 [thread overview]
Message-ID: <201102281454.32221.pedro@codesourcery.com> (raw)
In-Reply-To: <20110228140639.GG30306@adacore.com>
On Monday 28 February 2011 14:06:39, Joel Brobecker wrote:
> > > gdb/
> > >
> > > * linux-nat.c: Move common macros to ...
> > > Include linux-ptrace.h.
> > > * common/linux-ptrace.h: ... here. New.
> > >
> > > gdb/gdbserver/
> > >
> > > * linux-low.c: Move common macros to linux-ptrace.h.
> > > Include linux-ptrace.h.
> > > * Makefile.in (linux_ptrace_h): New.
> > > (linux-low.o): Depends on linux-ptrace.h.
>
> Speaking of which, what was the latest decision regarding the
> way we would handle the sources in common/. I thought that we
> were going to delete the configury and Makefile, and treat this
> the same way we treat the gnulib/ directory. Was that ever
> decided? I personally would like to give this idea a try and
> see where it goes, but I'm not enough of an expert to really
> predict whether it's going to be better or not. I can look
> at producing patches, though.
IMO, we should go ahead with
that, see <http://sourceware.org/ml/gdb-patches/2011-02/msg00657.html>.
In sum, I'm convinced the trouble of listing an object
in two Makefiles is negligiceably compared to the pain
we've been getting ourselves into as long as:
- the core set of headers between gdb and gdbserver aren't
harmonized/shared, and,
- we still need to maintain separate AC_CHECK_HEADERS & co
in gdb's and gdbserver's configury&makefilery.
This one is a major point against the current status
quo, IMO.
I've pointed out Yet Another Way to handle this in the
url above (but as I said there, I'm not sure we want
to be playing with this stuff at this time). And
it may be well be a totally stupid idea. :-)
--
Pedro Alves
next prev parent reply other threads:[~2011-02-28 14:54 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 8:24 [common] Merge duplicated macros in linux-nat.c and linux-low.c Yao Qi
2011-02-18 9:36 ` Jan Kratochvil
2011-02-18 14:54 ` Yao Qi
2011-02-18 15:14 ` Mark Kettenis
2011-02-18 16:14 ` Pedro Alves
2011-02-18 15:24 ` Tom Tromey
2011-02-18 15:46 ` Yao Qi
2011-02-18 15:55 ` Tom Tromey
2011-02-18 15:52 ` Pedro Alves
2011-02-18 17:21 ` Yao Qi
2011-02-20 21:34 ` Yao Qi
2011-02-28 12:38 ` Ping: " Yao Qi
2011-02-28 14:35 ` question about the common/ subdir (was "Re: Ping: Merge duplicated macros in linux-nat.c and linux-low.c") Joel Brobecker
2011-02-28 14:54 ` Yao Qi
2011-02-28 15:11 ` Pedro Alves
2011-02-28 15:00 ` Pedro Alves [this message]
2011-03-11 5:05 ` Ping: Merge duplicated macros in linux-nat.c and linux-low.c Yao Qi
2011-03-29 7:46 ` Yao Qi
2011-04-07 14:06 ` Yao Qi
2011-04-25 17:04 ` [common] " Tom Tromey
2011-04-26 15:39 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102281454.32221.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox