From: Yao Qi <yao@codesourcery.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c
Date: Fri, 18 Feb 2011 17:21:00 -0000 [thread overview]
Message-ID: <4D5EA533.608@codesourcery.com> (raw)
In-Reply-To: <201102181546.26744.pedro@codesourcery.com>
On 02/18/2011 11:46 PM, Pedro Alves wrote:
> Let's name the files according to their contents instead.
> Let's take the opportunity to split independent things
> into separate files if it makes sense to factor them out.
>
Yes, I agree. There have been some files named *-common in my local
gdb/common/ dir. :) They look odd on name.
> E.g., x86 watchpoint related macros -> x86-watch.h
> or x86-nat-watch.h or i386-watchpoint.h, or something
> like that, not x86-common.h.
>
> E.g., linux ptrace related macros and definition
> -> linux-ptrace.h or something like that.
>
Looks good to me. I'll name my files in this way.
--
Yao (é½å°§)
next prev parent reply other threads:[~2011-02-18 16:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 8:24 Yao Qi
2011-02-18 9:36 ` Jan Kratochvil
2011-02-18 14:54 ` Yao Qi
2011-02-18 15:14 ` Mark Kettenis
2011-02-18 16:14 ` Pedro Alves
2011-02-18 15:24 ` Tom Tromey
2011-02-18 15:46 ` Yao Qi
2011-02-18 15:55 ` Tom Tromey
2011-02-18 15:52 ` Pedro Alves
2011-02-18 17:21 ` Yao Qi [this message]
2011-02-20 21:34 ` Yao Qi
2011-02-28 12:38 ` Ping: " Yao Qi
2011-02-28 14:35 ` question about the common/ subdir (was "Re: Ping: Merge duplicated macros in linux-nat.c and linux-low.c") Joel Brobecker
2011-02-28 14:54 ` Yao Qi
2011-02-28 15:11 ` Pedro Alves
2011-02-28 15:00 ` Pedro Alves
2011-03-11 5:05 ` Ping: Merge duplicated macros in linux-nat.c and linux-low.c Yao Qi
2011-03-29 7:46 ` Yao Qi
2011-04-07 14:06 ` Yao Qi
2011-04-25 17:04 ` [common] " Tom Tromey
2011-04-26 15:39 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5EA533.608@codesourcery.com \
--to=yao@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox