From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7780 invoked by alias); 18 Feb 2011 16:58:31 -0000 Received: (qmail 7762 invoked by uid 22791); 18 Feb 2011 16:58:30 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 16:58:26 +0000 Received: (qmail 21012 invoked from network); 18 Feb 2011 16:58:24 -0000 Received: from unknown (HELO ?192.168.0.101?) (yao@127.0.0.2) by mail.codesourcery.com with ESMTPA; 18 Feb 2011 16:58:24 -0000 Message-ID: <4D5EA533.608@codesourcery.com> Date: Fri, 18 Feb 2011 17:21:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.13) Gecko/20101208 Lightning/1.0b2 Thunderbird/3.1.7 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c References: <4D5E2021.2070107@codesourcery.com> <201102181546.26744.pedro@codesourcery.com> In-Reply-To: <201102181546.26744.pedro@codesourcery.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-02/txt/msg00477.txt.bz2 On 02/18/2011 11:46 PM, Pedro Alves wrote: > Let's name the files according to their contents instead. > Let's take the opportunity to split independent things > into separate files if it makes sense to factor them out. > Yes, I agree. There have been some files named *-common in my local gdb/common/ dir. :) They look odd on name. > E.g., x86 watchpoint related macros -> x86-watch.h > or x86-nat-watch.h or i386-watchpoint.h, or something > like that, not x86-common.h. > > E.g., linux ptrace related macros and definition > -> linux-ptrace.h or something like that. > Looks good to me. I'll name my files in this way. -- Yao (齐尧)