From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
Cc: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c
Date: Fri, 18 Feb 2011 15:14:00 -0000 [thread overview]
Message-ID: <201102181458.p1IEwrxd030570@glazunov.sibelius.xs4all.nl> (raw)
In-Reply-To: <4D5E8516.9010105@codesourcery.com> (message from Yao Qi on Fri, 18 Feb 2011 22:41:26 +0800)
> Date: Fri, 18 Feb 2011 22:41:26 +0800
> From: Yao Qi <yao@codesourcery.com>
> +#include <sys/ptrace.h>
> +
You only include <sys/ptrace.h> in this header file, but...
> +
> +#ifndef O_LARGEFILE
> +#define O_LARGEFILE 0
> +#endif
> +
> +/* We can't always assume that this flag is available, but all systems
> + with the ptrace event handlers also have __WALL, so it's safe to use
> + in some contexts. */
> +#ifndef __WALL
> +#define __WALL 0x40000000 /* Wait for any child. */
> +#endif
...I don't think O_LARGEFILE and __WALL are declared in that header
file. I wonder if you should also include <fcntl.h> and <sys/wait.h>
here, to make sure you don't accidentally define them to some bogus
value when the Linux system does provide the proper defines for them.
Cheers,
Mark
next prev parent reply other threads:[~2011-02-18 15:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 8:24 Yao Qi
2011-02-18 9:36 ` Jan Kratochvil
2011-02-18 14:54 ` Yao Qi
2011-02-18 15:14 ` Mark Kettenis [this message]
2011-02-18 16:14 ` Pedro Alves
2011-02-18 15:24 ` Tom Tromey
2011-02-18 15:46 ` Yao Qi
2011-02-18 15:55 ` Tom Tromey
2011-02-18 15:52 ` Pedro Alves
2011-02-18 17:21 ` Yao Qi
2011-02-20 21:34 ` Yao Qi
2011-02-28 12:38 ` Ping: " Yao Qi
2011-02-28 14:35 ` question about the common/ subdir (was "Re: Ping: Merge duplicated macros in linux-nat.c and linux-low.c") Joel Brobecker
2011-02-28 14:54 ` Yao Qi
2011-02-28 15:11 ` Pedro Alves
2011-02-28 15:00 ` Pedro Alves
2011-03-11 5:05 ` Ping: Merge duplicated macros in linux-nat.c and linux-low.c Yao Qi
2011-03-29 7:46 ` Yao Qi
2011-04-07 14:06 ` Yao Qi
2011-04-25 17:04 ` [common] " Tom Tromey
2011-04-26 15:39 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201102181458.p1IEwrxd030570@glazunov.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox