From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-78394-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10911 invoked by alias); 18 Feb 2011 15:01:50 -0000
Received: (qmail 10903 invoked by uid 22791); 18 Feb 2011 15:01:50 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0	tests=AWL,BAYES_00,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO glazunov.sibelius.xs4all.nl) (83.163.83.176)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 18 Feb 2011 15:01:45 +0000
Received: from glazunov.sibelius.xs4all.nl (kettenis@localhost [127.0.0.1])	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id p1IEwtHw008182;	Fri, 18 Feb 2011 15:58:55 +0100 (CET)
Received: (from kettenis@localhost)	by glazunov.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id p1IEwrxd030570;	Fri, 18 Feb 2011 15:58:53 +0100 (CET)
Date: Fri, 18 Feb 2011 15:14:00 -0000
Message-Id: <201102181458.p1IEwrxd030570@glazunov.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: yao@codesourcery.com
CC: jan.kratochvil@redhat.com, gdb-patches@sourceware.org
In-reply-to: <4D5E8516.9010105@codesourcery.com> (message from Yao Qi on Fri,	18 Feb 2011 22:41:26 +0800)
Subject: Re: [common] Merge duplicated macros in linux-nat.c and linux-low.c
References: <4D5E2021.2070107@codesourcery.com> <20110218082420.GA18856@host1.dyn.jankratochvil.net> <4D5E8516.9010105@codesourcery.com>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2011-02/txt/msg00461.txt.bz2

> Date: Fri, 18 Feb 2011 22:41:26 +0800
> From: Yao Qi <yao@codesourcery.com>

> +#include <sys/ptrace.h>
> +

You only include <sys/ptrace.h> in this header file, but...

> +
> +#ifndef O_LARGEFILE
> +#define O_LARGEFILE 0
> +#endif
> +
> +/* We can't always assume that this flag is available, but all systems
> +   with the ptrace event handlers also have __WALL, so it's safe to use
> +   in some contexts.  */
> +#ifndef __WALL
> +#define __WALL          0x40000000 /* Wait for any child.  */
> +#endif

...I don't think O_LARGEFILE and __WALL are declared in that header
file.  I wonder if you should also include <fcntl.h> and <sys/wait.h>
here, to make sure you don't accidentally define them to some bogus
value when the Linux system does provide the proper defines for them.

Cheers,

Mark