Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: nickrob@snap.net.nz (Nick Roberts)
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: implement new dynamic varobj spec
Date: Mon, 14 Sep 2009 20:12:00 -0000	[thread overview]
Message-ID: <m3vdjl5lr8.fsf@fleche.redhat.com> (raw)
In-Reply-To: <19116.23500.574462.227048@totara.tehura.co.nz> (Nick Roberts's 	message of "Sun, 13 Sep 2009 14:41:16 +1200")

>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:

Nick> 2) -var-update seems to list changes to children of dynamic
Nick> objects in reverse numerical order.

Tom> Oh, odd.  But not a bug, really, as the order is not specified.

Nick> It might not be a bug but it's desirable to list them in order as
Nick> that makes it easier to insert them into the existing list.

Ok, I will look into this.

Nick> In fact it would also make things easier if the "exp" field of
Nick> -var-list-children was just a number and this would make it
Nick> consistent with ordinary arrays.

The children might not actually represent an array.  For example, they
may conceptually be fields of a struct.

Nick> +	  /* Strip square brackets from string.  */
Nick> +	  len = strlen (py_name);
Nick> +	  name = strndup (py_name + 1, len - 2);

There is nothing guaranteeing square brackets about the name.  The name
is determined wholly by the Python pretty-printer, which can return
anything at all.

I would prefer not to change this.  I think front ends simply have to
treat the child name as an arbitrary string.  They can use the display
hint to decide how and if to display the name.

Tom


  reply	other threads:[~2009-09-14 20:12 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-13  2:41 Nick Roberts
2009-09-14 20:12 ` Tom Tromey [this message]
2009-09-14 20:21   ` Tom Tromey
2009-09-15  0:03     ` Nick Roberts
2009-09-14 23:48   ` Nick Roberts
2009-09-15 15:38     ` Tom Tromey
  -- strict thread matches above, loose matches on Subject: below --
2009-09-10 20:58 Tom Tromey
2009-09-11  5:41 ` Nick Roberts
2009-09-11 19:41   ` Tom Tromey
2009-09-11 20:49     ` Eli Zaretskii
2009-09-11 21:12       ` Tom Tromey
2009-09-12  8:08         ` Eli Zaretskii
2009-09-11 23:55     ` Nick Roberts
2009-09-14 19:59       ` Tom Tromey
2009-09-14 22:55         ` Nick Roberts
2009-09-15 15:37           ` Tom Tromey
2009-09-15 22:28             ` Nick Roberts
2009-09-16  5:45               ` Vladimir Prus
2009-09-16  9:56                 ` Nick Roberts
2009-09-16 17:12               ` Tom Tromey
2009-09-16 22:26                 ` Nick Roberts
2009-09-15 22:43             ` Nick Roberts
2009-09-16  5:39               ` Vladimir Prus
2009-09-16  9:36                 ` Nick Roberts
2009-09-16  5:44         ` Vladimir Prus
2009-09-14 19:56   ` Tom Tromey
2009-09-12  9:18 ` Eli Zaretskii
2009-09-14 20:03   ` Tom Tromey
2009-09-14 20:22     ` Eli Zaretskii
2009-09-14 21:29       ` Tom Tromey
2009-09-15  3:06         ` Eli Zaretskii
2009-09-14 11:24 ` Vladimir Prus
2009-09-16 23:53   ` Tom Tromey
2009-09-16  5:46     ` Vladimir Prus
2009-09-19 12:01     ` Matt Rice
2009-09-19 15:59       ` Joel Brobecker
2009-09-14 20:05 ` Tom Tromey
2009-09-14 20:24   ` Eli Zaretskii
2009-09-14 23:58   ` Nick Roberts
2009-09-18  9:29 ` Vladimir Prus
2009-09-18 18:25   ` Tom Tromey
2009-09-19 12:57   ` Vladimir Prus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vdjl5lr8.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox