From: Vladimir Prus <vladimir@codesourcery.com>
To: gdb-patches@sources.redhat.com
Subject: Re: Patch: implement new dynamic varobj spec
Date: Fri, 18 Sep 2009 09:29:00 -0000 [thread overview]
Message-ID: <h8vjtt$fqc$1@ger.gmane.org> (raw)
In-Reply-To: <m3r5uejz4y.fsf@fleche.redhat.com>
Tom Tromey wrote:
> This is the long-awaited dynamic varobj patch.
> It implements the spec as described by Vladimir:
>
> http://sourceware.org/ml/gdb/2009-07/msg00088.html
>
> .. with various minor changes we've discussed on that thread and
> elsewhere. I didn't give the follow-up URLs; I think that the doc patch
> ought to be sufficient, and if it isn't, I will fix it up.
>
> This has been in development for quite a while, including testing using
> two different MI consumers (Vladimir's and one by Noam Yorav-Raphael).
>
> There are three outstanding bugs.
>
> * A dynamic varobj bug that I couldn't reproduce
> http://sourceware.org/ml/archer/2009-q3/msg00169.html
I've got with gdb-inside-gdb. What happens is:
- we have uninitialized std::vector<std::string> (did I already say that gcc produces
bogus debug info?)
- The 'strings' at the address where supposed storage of the bogus vector is
point nowhere.
- When Python code tries to pretty-print inaccassible memory, it gives:
Traceback (most recent call last):
File "/home/ghost/Build/python/libstdcxx/v6/printers.py", line 469, in to_string
return self.val['_M_dataplus']['_M_p'].string (encoding, length = len)
RuntimeError: Cannot access memory at address 0xcf
- Inside GDB, pretty_print_one_value catches the above exception, and returns 0.
- The rest of GDB fallbacks to printing the value as it would without Python
pretty-printing. And with 'set print pretty 1', it pretty-prints the raw value.
I think there are two things worth fixing:
1. set print pretty 1 should have no effect on MI. I can handle this part.
2. pretty-printer for string should catch exception and return "<inaccessible>"
or some such. Alternatively, GDB should not fallback to regular display if
Python pretty-printer fails. Yet alternatively, GDB should distinguish between
different failure modes of Python pretty-printer, since memory access error
likely to be caused by uninitalized data and should not cause fallback.
Does this make any sense?
- Volodya
next prev parent reply other threads:[~2009-09-18 9:29 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 20:58 Tom Tromey
2009-09-11 5:41 ` Nick Roberts
2009-09-11 19:41 ` Tom Tromey
2009-09-11 20:49 ` Eli Zaretskii
2009-09-11 21:12 ` Tom Tromey
2009-09-12 8:08 ` Eli Zaretskii
2009-09-11 23:55 ` Nick Roberts
2009-09-14 19:59 ` Tom Tromey
2009-09-14 22:55 ` Nick Roberts
2009-09-15 15:37 ` Tom Tromey
2009-09-15 22:28 ` Nick Roberts
2009-09-16 5:45 ` Vladimir Prus
2009-09-16 9:56 ` Nick Roberts
2009-09-16 17:12 ` Tom Tromey
2009-09-16 22:26 ` Nick Roberts
2009-09-15 22:43 ` Nick Roberts
2009-09-16 5:39 ` Vladimir Prus
2009-09-16 9:36 ` Nick Roberts
2009-09-16 5:44 ` Vladimir Prus
2009-09-16 23:52 ` RFA: mark -enable-pretty-printing as experimental (Was: Patch: implement new dynamic varobj spec) Tom Tromey
[not found] ` <h8vk80$fqc$2@ger.gmane.org>
2009-09-18 10:02 ` Eli Zaretskii
2009-09-18 18:01 ` RFA: mark -enable-pretty-printing as experimental Tom Tromey
2009-09-14 19:56 ` Patch: implement new dynamic varobj spec Tom Tromey
2009-09-12 9:18 ` Eli Zaretskii
2009-09-14 20:03 ` Tom Tromey
2009-09-14 20:22 ` Eli Zaretskii
2009-09-14 21:29 ` Tom Tromey
2009-09-15 3:06 ` Eli Zaretskii
2009-09-14 11:24 ` Vladimir Prus
2009-09-16 23:53 ` Tom Tromey
2009-09-16 5:46 ` Vladimir Prus
2009-09-19 12:01 ` Matt Rice
2009-09-19 15:59 ` Joel Brobecker
2009-09-14 20:05 ` Tom Tromey
2009-09-14 20:24 ` Eli Zaretskii
2009-09-14 23:58 ` Nick Roberts
2009-09-18 9:29 ` Vladimir Prus [this message]
2009-09-18 18:25 ` Tom Tromey
2009-09-19 12:57 ` Vladimir Prus
2009-09-13 2:41 Nick Roberts
2009-09-14 20:12 ` Tom Tromey
2009-09-14 20:21 ` Tom Tromey
2009-09-15 0:03 ` Nick Roberts
2009-09-14 23:48 ` Nick Roberts
2009-09-15 15:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h8vjtt$fqc$1@ger.gmane.org' \
--to=vladimir@codesourcery.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox