Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: nickrob@snap.net.nz (Nick Roberts)
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: implement new dynamic varobj spec
Date: Wed, 16 Sep 2009 17:12:00 -0000	[thread overview]
Message-ID: <m33a6mstj1.fsf@fleche.redhat.com> (raw)
In-Reply-To: <19120.5383.874148.235514@totara.tehura.co.nz> (Nick Roberts's 	message of "Wed, 16 Sep 2009 10:28:23 +1200")

>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:

Tom> With a dynamic varobj you can tell if it has children by examining the
Tom> has_more attribute.

Nick> The field has_more tells you if it _currently_ has children.  If
Nick> you create a variable object of a STL container immediately after
Nick> declaring an empty container, e.g. after

Ok, yeah, I see what you mean.

Nick>   map<string, int> m;
Nick> then has_more=0 yet the node for it would need to be expandable.

I don't think I understand this, though.  There would be nothing
underneath the node.  So, showing some expansion control would be weird,
wouldn't it?

Nick> AFAICS the only way the front end can discriminate is through the
Nick> displayhint field.

I would like the display hint to remain just a hint.  In particular I
think it is important for future backward compatibility that we don't
require all front ends to know about all possible hints -- that is, it
should always be ok for the front end to ignore a hint it doesn't
understand.

So, if we need a way to determine "might possibly have children", then
let's add a new attribute.

Nick> On that note, printers.py in libstdc++ doesn't have a displayhint
Nick> function for StdListPrinter.

I'll look into this.  I'm not sure whether this was intentional or not.

Nick> Also there appears to be something wrong with the python class
Nick> StdVectorPrinter because if you create a variable object immediately after
Nick> declaring it, e.g. after

I'll look at this too, thanks.

Tom


  parent reply	other threads:[~2009-09-16 17:12 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-10 20:58 Tom Tromey
2009-09-11  5:41 ` Nick Roberts
2009-09-11 19:41   ` Tom Tromey
2009-09-11 20:49     ` Eli Zaretskii
2009-09-11 21:12       ` Tom Tromey
2009-09-12  8:08         ` Eli Zaretskii
2009-09-11 23:55     ` Nick Roberts
2009-09-14 19:59       ` Tom Tromey
2009-09-14 22:55         ` Nick Roberts
2009-09-15 15:37           ` Tom Tromey
2009-09-15 22:28             ` Nick Roberts
2009-09-16  5:45               ` Vladimir Prus
2009-09-16  9:56                 ` Nick Roberts
2009-09-16 17:12               ` Tom Tromey [this message]
2009-09-16 22:26                 ` Nick Roberts
2009-09-15 22:43             ` Nick Roberts
2009-09-16  5:39               ` Vladimir Prus
2009-09-16  9:36                 ` Nick Roberts
2009-09-16  5:44         ` Vladimir Prus
2009-09-16 23:52           ` RFA: mark -enable-pretty-printing as experimental (Was: Patch: implement new dynamic varobj spec) Tom Tromey
     [not found]             ` <h8vk80$fqc$2@ger.gmane.org>
2009-09-18 10:02               ` Eli Zaretskii
2009-09-18 18:01                 ` RFA: mark -enable-pretty-printing as experimental Tom Tromey
2009-09-14 19:56   ` Patch: implement new dynamic varobj spec Tom Tromey
2009-09-12  9:18 ` Eli Zaretskii
2009-09-14 20:03   ` Tom Tromey
2009-09-14 20:22     ` Eli Zaretskii
2009-09-14 21:29       ` Tom Tromey
2009-09-15  3:06         ` Eli Zaretskii
2009-09-14 11:24 ` Vladimir Prus
2009-09-16 23:53   ` Tom Tromey
2009-09-16  5:46     ` Vladimir Prus
2009-09-19 12:01     ` Matt Rice
2009-09-19 15:59       ` Joel Brobecker
2009-09-14 20:05 ` Tom Tromey
2009-09-14 20:24   ` Eli Zaretskii
2009-09-14 23:58   ` Nick Roberts
2009-09-18  9:29 ` Vladimir Prus
2009-09-18 18:25   ` Tom Tromey
2009-09-19 12:57   ` Vladimir Prus
2009-09-13  2:41 Nick Roberts
2009-09-14 20:12 ` Tom Tromey
2009-09-14 20:21   ` Tom Tromey
2009-09-15  0:03     ` Nick Roberts
2009-09-14 23:48   ` Nick Roberts
2009-09-15 15:38     ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m33a6mstj1.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nickrob@snap.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox