From: Tom Tromey <tromey@redhat.com>
To: nickrob@snap.net.nz (Nick Roberts)
Cc: gdb-patches@sourceware.org
Subject: Re: Patch: implement new dynamic varobj spec
Date: Tue, 15 Sep 2009 15:37:00 -0000 [thread overview]
Message-ID: <m3r5u8z0b2.fsf@fleche.redhat.com> (raw)
In-Reply-To: <19118.51646.285931.86868@totara.tehura.co.nz> (Nick Roberts's message of "Tue, 15 Sep 2009 10:54:54 +1200")
>>>>> "Nick" == Nick Roberts <nickrob@snap.net.nz> writes:
Nick> I don't know if others are already using these features but it
Nick> would seem sensible to me for frontends to _drive_ MI and not for
Nick> it to be the other way around.
Yeah; the first very round of code was really done in isolation but
since then, Vladimir has been trying things out in his GUI, and we've
had another user doing the same.
Nick> 1) The displayhint field output from -var-create as well/or
Nick> instead of from -var-list-children. That would be useful for
Nick> determining whether an element should be expandable or not. Types
Nick> map, list -- yes, type string -- no. With normal variable objects
Nick> I just use num_children but this isn't sufficient for dynamic
Nick> ones.
I can add displayhint to the -var-create output quite easily. It seems
like a good idea; I will implement it soon.
With a dynamic varobj you can tell if it has children by examining the
has_more attribute.
Nick> 2) If is_map is true, rather than:
[...]
Nick> I would prefer GDB to output:
Nick> var1.0 = "map_element"
Nick> var1.0.key = key0
Nick> var1.0.value = value0
Nick> That way the values could be displayed as a tree:
I considered this back at the start. The problem with doing this is
that the key need not be a scalar. It could be a struct or some other
complicated varobj with children.
Also, the current approach has a benefit because it is simple and
uniform: we can add more display hints without modifying the C code.
Tom
next prev parent reply other threads:[~2009-09-15 15:37 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 20:58 Tom Tromey
2009-09-11 5:41 ` Nick Roberts
2009-09-11 19:41 ` Tom Tromey
2009-09-11 20:49 ` Eli Zaretskii
2009-09-11 21:12 ` Tom Tromey
2009-09-12 8:08 ` Eli Zaretskii
2009-09-11 23:55 ` Nick Roberts
2009-09-14 19:59 ` Tom Tromey
2009-09-14 22:55 ` Nick Roberts
2009-09-15 15:37 ` Tom Tromey [this message]
2009-09-15 22:28 ` Nick Roberts
2009-09-16 5:45 ` Vladimir Prus
2009-09-16 9:56 ` Nick Roberts
2009-09-16 17:12 ` Tom Tromey
2009-09-16 22:26 ` Nick Roberts
2009-09-15 22:43 ` Nick Roberts
2009-09-16 5:39 ` Vladimir Prus
2009-09-16 9:36 ` Nick Roberts
2009-09-16 5:44 ` Vladimir Prus
2009-09-16 23:52 ` RFA: mark -enable-pretty-printing as experimental (Was: Patch: implement new dynamic varobj spec) Tom Tromey
[not found] ` <h8vk80$fqc$2@ger.gmane.org>
2009-09-18 10:02 ` Eli Zaretskii
2009-09-18 18:01 ` RFA: mark -enable-pretty-printing as experimental Tom Tromey
2009-09-14 19:56 ` Patch: implement new dynamic varobj spec Tom Tromey
2009-09-12 9:18 ` Eli Zaretskii
2009-09-14 20:03 ` Tom Tromey
2009-09-14 20:22 ` Eli Zaretskii
2009-09-14 21:29 ` Tom Tromey
2009-09-15 3:06 ` Eli Zaretskii
2009-09-14 11:24 ` Vladimir Prus
2009-09-16 23:53 ` Tom Tromey
2009-09-16 5:46 ` Vladimir Prus
2009-09-19 12:01 ` Matt Rice
2009-09-19 15:59 ` Joel Brobecker
2009-09-14 20:05 ` Tom Tromey
2009-09-14 20:24 ` Eli Zaretskii
2009-09-14 23:58 ` Nick Roberts
2009-09-18 9:29 ` Vladimir Prus
2009-09-18 18:25 ` Tom Tromey
2009-09-19 12:57 ` Vladimir Prus
2009-09-13 2:41 Nick Roberts
2009-09-14 20:12 ` Tom Tromey
2009-09-14 20:21 ` Tom Tromey
2009-09-15 0:03 ` Nick Roberts
2009-09-14 23:48 ` Nick Roberts
2009-09-15 15:38 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3r5u8z0b2.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=nickrob@snap.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox