From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7888 invoked by alias); 14 Sep 2009 20:12:33 -0000 Received: (qmail 7880 invoked by uid 22791); 14 Sep 2009 20:12:32 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 14 Sep 2009 20:12:27 +0000 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n8EKCD6w031081; Mon, 14 Sep 2009 16:12:14 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx08.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n8EKCCmL000655; Mon, 14 Sep 2009 16:12:13 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n8EKCChS004949; Mon, 14 Sep 2009 16:12:12 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id CDC84378175; Mon, 14 Sep 2009 14:12:11 -0600 (MDT) From: Tom Tromey To: nickrob@snap.net.nz (Nick Roberts) Cc: gdb-patches@sourceware.org Subject: Re: Patch: implement new dynamic varobj spec References: <19116.23500.574462.227048@totara.tehura.co.nz> Reply-To: Tom Tromey Date: Mon, 14 Sep 2009 20:12:00 -0000 In-Reply-To: <19116.23500.574462.227048@totara.tehura.co.nz> (Nick Roberts's message of "Sun, 13 Sep 2009 14:41:16 +1200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00449.txt.bz2 >>>>> "Nick" == Nick Roberts writes: Nick> 2) -var-update seems to list changes to children of dynamic Nick> objects in reverse numerical order. Tom> Oh, odd. But not a bug, really, as the order is not specified. Nick> It might not be a bug but it's desirable to list them in order as Nick> that makes it easier to insert them into the existing list. Ok, I will look into this. Nick> In fact it would also make things easier if the "exp" field of Nick> -var-list-children was just a number and this would make it Nick> consistent with ordinary arrays. The children might not actually represent an array. For example, they may conceptually be fields of a struct. Nick> + /* Strip square brackets from string. */ Nick> + len = strlen (py_name); Nick> + name = strndup (py_name + 1, len - 2); There is nothing guaranteeing square brackets about the name. The name is determined wholly by the Python pretty-printer, which can return anything at all. I would prefer not to change this. I think front ends simply have to treat the child name as an arbitrary string. They can use the display hint to decide how and if to display the name. Tom