From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>,
Joel Brobecker <brobecker@adacore.com>,
"gdb-patches\@sourceware.org"
<gdb-patches@sourceware.org>
Subject: Re: [RFA] let record_resume fail immediately on error
Date: Tue, 10 Nov 2009 22:05:00 -0000 [thread overview]
Message-ID: <m3vdhi9gtw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <daef60380911092301t5da31e96g7e579c2e9b35d9fb@mail.gmail.com> (Hui Zhu's message of "Tue, 10 Nov 2009 15:01:54 +0800")
>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:
>> It add a new argument "catch" to do_record_message. If catch is true,
>> it will call "record_message" with catch errors. If not, it will call
>> "record_message" directly.
I don't like this much either. It is trivial for callers that want to
catch errors to catch them. They can use TRY_CATCH or catch_errors(...,
record_message).
Callers that don't want to catch errors should just call
do_record_message directly. This is both for type safety and also
because such calls are plain old C, and should therefore look like it.
Tom
next prev parent reply other threads:[~2009-11-10 22:05 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 4:03 Michael Snyder
2009-09-08 5:00 ` Hui Zhu
2009-09-08 6:59 ` Joel Brobecker
2009-09-08 7:23 ` Hui Zhu
2009-09-08 7:25 ` Hui Zhu
2009-09-08 7:53 ` Hui Zhu
2009-09-08 16:57 ` Michael Snyder
2009-09-09 2:05 ` Hui Zhu
2009-09-12 2:40 ` Hui Zhu
2009-09-24 3:10 ` Hui Zhu
2009-09-26 18:35 ` Michael Snyder
2009-09-27 2:51 ` Hui Zhu
2009-09-28 9:27 ` Hui Zhu
2009-09-28 18:12 ` Joel Brobecker
2009-09-29 2:33 ` Hui Zhu
2009-09-29 21:29 ` Joel Brobecker
2009-09-29 23:57 ` Hui Zhu
2009-10-14 2:10 ` Joel Brobecker
2009-10-14 2:28 ` Hui Zhu
2009-10-14 2:42 ` Joel Brobecker
2009-10-15 4:38 ` Hui Zhu
2009-10-15 4:58 ` Joel Brobecker
2009-10-15 7:17 ` Hui Zhu
2009-10-15 16:23 ` Joel Brobecker
2009-10-15 17:18 ` Michael Snyder
2009-10-16 3:37 ` Hui Zhu
2009-10-20 3:17 ` Hui Zhu
2009-10-23 7:29 ` Hui Zhu
2009-11-03 2:17 ` Hui Zhu
2009-11-03 18:57 ` Michael Snyder
2009-11-04 5:15 ` Hui Zhu
2009-11-10 7:02 ` Hui Zhu
2009-11-10 22:05 ` Tom Tromey [this message]
2009-11-11 0:55 ` Hui Zhu
2009-11-24 6:16 ` Hui Zhu
2009-11-24 17:14 ` Tom Tromey
2009-11-25 2:00 ` Hui Zhu
2009-11-25 16:25 ` Joel Brobecker
2009-11-25 17:59 ` Tom Tromey
2009-11-26 6:40 ` Hui Zhu
2009-11-28 0:29 ` Hui Zhu
2009-12-01 22:27 ` Tom Tromey
2009-12-02 3:23 ` Hui Zhu
2009-12-07 15:01 ` Hui Zhu
2009-12-12 8:41 ` Hui Zhu
2009-12-21 20:45 ` Tom Tromey
2009-12-22 3:18 ` Hui Zhu
2009-09-08 16:54 ` Michael Snyder
2009-09-08 16:52 ` Michael Snyder
2009-09-08 16:50 ` Michael Snyder
2009-09-08 17:05 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdhi9gtw.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox