From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68328-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9630 invoked by alias); 10 Nov 2009 22:05:32 -0000
Received: (qmail 9621 invoked by uid 22791); 10 Nov 2009 22:05:32 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Nov 2009 22:05:26 +0000
Received: from int-mx05.intmail.prod.int.phx2.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.18]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAAM52fU007379 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Tue, 10 Nov 2009 17:05:02 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx05.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAAM51xm013384; 	Tue, 10 Nov 2009 17:05:01 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAAM50ib014631; 	Tue, 10 Nov 2009 17:05:00 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id C48663782CF; Tue, 10 Nov 2009 15:04:59 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Hui Zhu <teawater@gmail.com>
Cc: Michael Snyder <msnyder@vmware.com>,         Joel Brobecker <brobecker@adacore.com>,         "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [RFA] let record_resume fail immediately on error
References: <20090928160728.GB9003@adacore.com> 	<daef60380910150016o2a47894fpbf5ac4657be716d6@mail.gmail.com> 	<20091015162326.GA5272@adacore.com> <4AD75806.9070705@vmware.com> 	<daef60380910152036t1fdfc3edqc8f95980b466266d@mail.gmail.com> 	<daef60380910192017x67a5f208ma06424cc386880d8@mail.gmail.com> 	<daef60380910230029v4e794c0s112b50858de3a22@mail.gmail.com> 	<daef60380911021817g4ff471echd087ef05e9f94c19@mail.gmail.com> 	<4AF07CF2.1050902@vmware.com> 	<daef60380911032115v69167866o65c3b90e4622a382@mail.gmail.com> 	<daef60380911092301t5da31e96g7e579c2e9b35d9fb@mail.gmail.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Tue, 10 Nov 2009 22:05:00 -0000
In-Reply-To: <daef60380911092301t5da31e96g7e579c2e9b35d9fb@mail.gmail.com> 	(Hui Zhu's message of "Tue, 10 Nov 2009 15:01:54 +0800")
Message-ID: <m3vdhi9gtw.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00235.txt.bz2

>>>>> ">" == Hui Zhu <teawater@gmail.com> writes:

>> It add a new argument "catch" to do_record_message.  If catch is true,
>> it will call "record_message" with catch errors.  If not, it will call
>> "record_message" directly.

I don't like this much either.  It is trivial for callers that want to
catch errors to catch them.  They can use TRY_CATCH or catch_errors(...,
record_message).

Callers that don't want to catch errors should just call
do_record_message directly.  This is both for type safety and also
because such calls are plain old C, and should therefore look like it.

Tom