From: Tom Tromey <tromey@redhat.com>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, Hui Zhu <teawater@gmail.com>,
Joel Brobecker <brobecker@adacore.com>,
Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
Date: Fri, 09 Apr 2010 18:14:00 -0000 [thread overview]
Message-ID: <m3vdc0jxxm.fsf@fleche.redhat.com> (raw)
In-Reply-To: <1270786615-29934-1-git-send-email-crquan@gmail.com> (crquan@gmail.com's message of "Fri, 9 Apr 2010 12:16:55 +0800")
>>>>> ">" == crquan <crquan@gmail.com> writes:
>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>> add new support for disassemble by "start,+length" format;
Do you have a copyright assignment in place?
If not, let me know and I can get you started.
>> /* Two arguments. */
>> + int incl_flag = 0;
>> +
>> low = pc;
I think you should skip whitespace here.
>> + if (arg[0] == '+') {
The brace placement is wrong here. See the GNU Coding Standards, or
existing code in that function.
Otherwise this seems reasonable to me.
Tom
next prev parent reply other threads:[~2010-04-09 18:14 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 4:11 crquan
2010-04-09 8:22 ` Eli Zaretskii
2010-04-09 9:35 ` Cheng Renquan
2010-04-09 10:29 ` Eli Zaretskii
2010-04-09 18:14 ` Tom Tromey [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-04-10 21:01 crquan
2010-04-10 21:16 ` Eli Zaretskii
2010-04-10 21:23 ` Cheng Renquan
2010-04-13 23:29 ` Tom Tromey
2010-04-08 15:09 crquan
2010-04-09 2:16 ` Hui Zhu
2010-04-15 7:44 ` crquan
2010-04-15 17:08 ` Eli Zaretskii
2010-04-15 17:14 ` Nathan Froyd
2010-04-15 17:38 ` Eli Zaretskii
2010-04-16 1:36 ` crquan
2010-04-20 15:43 ` Tom Tromey
2010-04-20 18:43 ` crquan
2010-04-30 14:21 ` Hui Zhu
2010-07-09 2:53 ` crquan
2010-07-09 8:23 ` Eli Zaretskii
2010-07-09 11:32 ` crquan
2010-07-11 11:53 ` Hui Zhu
2010-07-11 17:28 ` Cheng Renquan
2010-07-27 16:04 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3vdc0jxxm.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=crquan@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox