From: Cheng Renquan <crquan@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org, teawater@gmail.com, brobecker@adacore.com
Subject: Re: [PATCH] disassemble support start,+length format
Date: Fri, 09 Apr 2010 09:35:00 -0000 [thread overview]
Message-ID: <h2l91b13c311004090234mb3611f38w726a93ab2bfbd549@mail.gmail.com> (raw)
In-Reply-To: <83wrwhyr18.fsf@gnu.org>
On Fri, Apr 9, 2010 at 4:21 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>> -* "disassemble" command with a /r modifier, print the raw instructions
>> -in hex as well as in symbolic form.
>> +* The "disassemble" command with an optional /r modifier, print the raw
>> +instructions in hex as well as in symbolic form; optional /m modifier to
>> +print mixed source+assembly.
>
> Thanks. But please use the style we use in other NEWS entries.
> Something like "The disassemble command now supports ..." etc.
The previous entries in "Changes in GDB 7.0" already have problems, I
should check,
>
>> +arguments specify a range of addresses, in the form of "start,end" or
>> +"start,+length", stand for [start,end) and [start,start+length), (first
>> +inclusive, second exclusive) to dump. In that case, the name of the
>> +function is also printed (since there could be several functions in the
>> +given range).
>
> I suggest to rephrase as follows:
>
> arguments specify a range of addresses to dump, in one of two forms:
>
> @table @code
> @item @var{start},@var{end}
> the addresses from @var{start} (inclusive) to @var{end} (exclusive)
> @item @var{start},+@var{length}
> the addresses from @var{start} (inclusive) to
> @code{@var{start}+@var{length}} (exclusive).
> @end table
>
> @noindent
> When 2 arguments are specified, the name of the function is also
> printed (since there could be several functions in the given range).
>
> Note that I used @var{start},@var{end}}, instead of using double
> quotes (which is generally a no-no in Texinfo sources).
OK, I really know little about texinfo writing; Thanks,
--
Cheng Renquan (程任全), from Singapore
next prev parent reply other threads:[~2010-04-09 9:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 4:11 crquan
2010-04-09 8:22 ` Eli Zaretskii
2010-04-09 9:35 ` Cheng Renquan [this message]
2010-04-09 10:29 ` Eli Zaretskii
2010-04-09 18:14 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2010-04-10 21:01 crquan
2010-04-10 21:16 ` Eli Zaretskii
2010-04-10 21:23 ` Cheng Renquan
2010-04-13 23:29 ` Tom Tromey
2010-04-08 15:09 crquan
2010-04-09 2:16 ` Hui Zhu
2010-04-15 7:44 ` crquan
2010-04-15 17:08 ` Eli Zaretskii
2010-04-15 17:14 ` Nathan Froyd
2010-04-15 17:38 ` Eli Zaretskii
2010-04-16 1:36 ` crquan
2010-04-20 15:43 ` Tom Tromey
2010-04-20 18:43 ` crquan
2010-04-30 14:21 ` Hui Zhu
2010-07-09 2:53 ` crquan
2010-07-09 8:23 ` Eli Zaretskii
2010-07-09 11:32 ` crquan
2010-07-11 11:53 ` Hui Zhu
2010-07-11 17:28 ` Cheng Renquan
2010-07-27 16:04 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=h2l91b13c311004090234mb3611f38w726a93ab2bfbd549@mail.gmail.com \
--to=crquan@gmail.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox