From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19076 invoked by alias); 9 Apr 2010 09:35:15 -0000 Received: (qmail 19068 invoked by uid 22791); 9 Apr 2010 09:35:15 -0000 X-SWARE-Spam-Status: No, hits=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SARE_MSGID_LONG45 X-Spam-Check-By: sourceware.org Received: from mail-vw0-f41.google.com (HELO mail-vw0-f41.google.com) (209.85.212.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 09:35:10 +0000 Received: by vws15 with SMTP id 15so111487vws.0 for ; Fri, 09 Apr 2010 02:35:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.82.211 with HTTP; Fri, 9 Apr 2010 02:34:48 -0700 (PDT) In-Reply-To: <83wrwhyr18.fsf@gnu.org> References: <1270786615-29934-1-git-send-email-crquan@gmail.com> <83wrwhyr18.fsf@gnu.org> From: Cheng Renquan Date: Fri, 09 Apr 2010 09:35:00 -0000 Received: by 10.220.123.104 with SMTP id o40mr931263vcr.208.1270805708146; Fri, 09 Apr 2010 02:35:08 -0700 (PDT) Message-ID: Subject: Re: [PATCH] disassemble support start,+length format To: Eli Zaretskii Cc: gdb-patches@sourceware.org, teawater@gmail.com, brobecker@adacore.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-04/txt/msg00225.txt.bz2 On Fri, Apr 9, 2010 at 4:21 PM, Eli Zaretskii wrote: >> -* "disassemble" command with a /r modifier, print the raw instructions >> -in hex as well as in symbolic form. >> +* The "disassemble" command with an optional /r modifier, print the raw >> +instructions in hex as well as in symbolic form; optional /m modifier to >> +print mixed source+assembly. > > Thanks. =C2=A0But please use the style we use in other NEWS entries. > Something like "The disassemble command now supports ..." etc. The previous entries in "Changes in GDB 7.0" already have problems, I should check, > >> +arguments specify a range of addresses, in the form of "start,end" or >> +"start,+length", stand for [start,end) and [start,start+length), (first >> +inclusive, second exclusive) to dump. =C2=A0In that case, the name of t= he >> +function is also printed (since there could be several functions in the >> +given range). > > I suggest to rephrase as follows: > > =C2=A0arguments specify a range of addresses to dump, in one of two forms: > > =C2=A0@table @code > =C2=A0@item @var{start},@var{end} > =C2=A0the addresses from @var{start} (inclusive) to @var{end} (exclusive) > =C2=A0@item @var{start},+@var{length} > =C2=A0the addresses from @var{start} (inclusive) to > =C2=A0@code{@var{start}+@var{length}} (exclusive). > =C2=A0@end table > > =C2=A0@noindent > =C2=A0When 2 arguments are specified, the name of the function is also > =C2=A0printed (since there could be several functions in the given range). > > Note that I used @var{start},@var{end}}, instead of using double > quotes (which is generally a no-no in Texinfo sources). OK, I really know little about texinfo writing; Thanks, --=20 Cheng Renquan (=E7=A8=8B=E4=BB=BB=E5=85=A8), from Singapore