From: Eli Zaretskii <eliz@gnu.org>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, tromey@redhat.com,
teawater@gmail.com, brobecker@adacore.com
Subject: Re: [PATCH] disassemble support start,+length format
Date: Thu, 15 Apr 2010 17:08:00 -0000 [thread overview]
Message-ID: <831vegy779.fsf@gnu.org> (raw)
In-Reply-To: <1271317836-12963-1-git-send-email-crquan@gmail.com>
> From: crquan@gmail.com
> Cc: Hui Zhu <teawater@gmail.com>,
> Joel Brobecker <brobecker@adacore.com>,
> Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 15 Apr 2010 15:50:36 +0800
>
> add new support for disassemble by "start,+length" format;
>
> update ChangeLog,NEWS,doc/gdb.texinfo accordingly.
> BTW, I found two disassemble Changes in GDB 7.0 in NEWS, separated in two
> paragraphs, so I merged them into one.
Thanks.
> gdb-7.1.50.20100415/gdb/ChangeLog | 8 +++++++-
> gdb-7.1.50.20100415/gdb/NEWS | 13 ++++++++-----
> gdb-7.1.50.20100415/gdb/cli/cli-cmds.c | 18 +++++++++++++++---
> gdb-7.1.50.20100415/gdb/doc/gdb.texinfo | 28 ++++++++++++++++++++++++++--
> 4 files changed, 56 insertions(+), 11 deletions(-)
Please also add an entry in gdb/doc/ChangeLog regarding the changes in
gdb/doc/gdb.texinfo.
> +@smallexample
> +(gdb) disas /r main,+20
> +Dump of assembler code from 0x450670 to 0x450684:
> + 0x0000000000450670 <main+0>: 48 83 ec 28 sub $0x28,%rsp
> + 0x0000000000450674 <main+4>: 48 c7 04 24 00 00 00 00 movq $0x0,(%rsp)
> + 0x000000000045067c <main+12>: 89 3c 24 mov %edi,(%rsp)
> + 0x000000000045067f <main+15>: 48 89 e7 mov %rsp,%rdi
> + 0x0000000000450682 <main+18>: 48 c7 44 24 10 00 00 00 00 movq $0x0,0x10(%rsp)
> +End of assembler dump.
> +@end smallexample
This is okay, but any line inside @smallexample block that is longer
than 72 characters will overflow the page margins in the printed
version of the manual. So could you perhaps select an example with
shorter lines?
Okay with that change.
next prev parent reply other threads:[~2010-04-15 17:08 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-08 15:09 crquan
2010-04-09 2:16 ` Hui Zhu
2010-04-15 7:44 ` crquan
2010-04-15 17:08 ` Eli Zaretskii [this message]
2010-04-15 17:14 ` Nathan Froyd
2010-04-15 17:38 ` Eli Zaretskii
2010-04-16 1:36 ` crquan
2010-04-20 15:43 ` Tom Tromey
2010-04-20 18:43 ` crquan
2010-04-30 14:21 ` Hui Zhu
2010-07-09 2:53 ` crquan
2010-07-09 8:23 ` Eli Zaretskii
2010-07-09 11:32 ` crquan
2010-07-11 11:53 ` Hui Zhu
2010-07-11 17:28 ` Cheng Renquan
2010-07-27 16:04 ` Joel Brobecker
2010-04-09 4:11 crquan
2010-04-09 8:22 ` Eli Zaretskii
2010-04-09 9:35 ` Cheng Renquan
2010-04-09 10:29 ` Eli Zaretskii
2010-04-09 18:14 ` Tom Tromey
2010-04-10 21:01 crquan
2010-04-10 21:16 ` Eli Zaretskii
2010-04-10 21:23 ` Cheng Renquan
2010-04-13 23:29 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831vegy779.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=crquan@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=teawater@gmail.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox