Re: [PATCH] disassemble support start,+length format

[Eli Zaretskii <eliz@gnu.org>]

> From: crquan@gmail.com
> Cc: Hui Zhu <teawater@gmail.com>, Joel Brobecker <brobecker@adacore.com>, CHENG Renquan <rqcheng@smu.edu.sg>
> Date: Fri,  9 Jul 2010 10:53:19 +0800
> 
> From: CHENG Renquan <rqcheng@smu.edu.sg>
> 
> add new support for disassemble by "start,+length" format;

Thanks.

> Index: gdb-7.2.50.20100708/gdb/NEWS
> ===================================================================
> --- gdb-7.2.50.20100708.orig/gdb/NEWS
> +++ gdb-7.2.50.20100708/gdb/NEWS

This part is okay.

> +      while (*arg == ' ' || *arg == '\t')

What's wrong with isspace?

> Index: gdb-7.2.50.20100708/gdb/doc/gdb.texinfo
> ===================================================================
> --- gdb-7.2.50.20100708.orig/gdb/doc/gdb.texinfo
> +++ gdb-7.2.50.20100708/gdb/doc/gdb.texinfo

This part is also okay, with a single comment:

> @@ -6736,8 +6736,19 @@ command is a program counter value; @val
>  surrounding this value.  When two arguments are given, they should
>  be separated by a comma, possibly surrounded by whitespace.  The
>  arguments specify a range of addresses (first inclusive, second exclusive)
> -to dump.  In that case, the name of the function is also printed (since
> -there could be several functions in the given range).
> +arguments specify a range of addresses to dump, in one of two forms:

I believe the previous line that begins with "arguments" should be
removed.

Thanks.