From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-74283-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21336 invoked by alias); 9 Jul 2010 08:23:40 -0000
Received: (qmail 21319 invoked by uid 22791); 9 Jul 2010 08:23:38 -0000
X-SWARE-Spam-Status: No, hits=0.8 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_JMF_BL,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Jul 2010 08:23:32 +0000
Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0L5A00J007B3WU00@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Fri, 09 Jul 2010 11:23:29 +0300 (IDT)
Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L5A00HW17B05H90@a-mtaout23.012.net.il>; Fri, 09 Jul 2010 11:23:26 +0300 (IDT)
Date: Fri, 09 Jul 2010 08:23:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
In-reply-to: <1278643999-4237-1-git-send-email-crquan@gmail.com>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, tromey@redhat.com, froydnj@codesourcery.com, teawater@gmail.com, brobecker@adacore.com, rqcheng@smu.edu.sg
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83fwztawvu.fsf@gnu.org>
References: <1271788793-26862-1-git-send-email-crquan@gmail.com> <1278643999-4237-1-git-send-email-crquan@gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-07/txt/msg00174.txt.bz2

> From: crquan@gmail.com
> Cc: Hui Zhu <teawater@gmail.com>, Joel Brobecker <brobecker@adacore.com>, CHENG Renquan <rqcheng@smu.edu.sg>
> Date: Fri,  9 Jul 2010 10:53:19 +0800
> 
> From: CHENG Renquan <rqcheng@smu.edu.sg>
> 
> add new support for disassemble by "start,+length" format;

Thanks.

> Index: gdb-7.2.50.20100708/gdb/NEWS
> ===================================================================
> --- gdb-7.2.50.20100708.orig/gdb/NEWS
> +++ gdb-7.2.50.20100708/gdb/NEWS

This part is okay.

> +      while (*arg == ' ' || *arg == '\t')

What's wrong with isspace?

> Index: gdb-7.2.50.20100708/gdb/doc/gdb.texinfo
> ===================================================================
> --- gdb-7.2.50.20100708.orig/gdb/doc/gdb.texinfo
> +++ gdb-7.2.50.20100708/gdb/doc/gdb.texinfo

This part is also okay, with a single comment:

> @@ -6736,8 +6736,19 @@ command is a program counter value; @val
>  surrounding this value.  When two arguments are given, they should
>  be separated by a comma, possibly surrounded by whitespace.  The
>  arguments specify a range of addresses (first inclusive, second exclusive)
> -to dump.  In that case, the name of the function is also printed (since
> -there could be several functions in the given range).
> +arguments specify a range of addresses to dump, in one of two forms:

I believe the previous line that begins with "arguments" should be
removed.

Thanks.