From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71953-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19384 invoked by alias); 9 Apr 2010 18:14:45 -0000
Received: (qmail 19374 invoked by uid 22791); 9 Apr 2010 18:14:44 -0000
X-SWARE-Spam-Status: No, hits=-6.8 required=5.0 	tests=BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CR,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Apr 2010 18:14:41 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o39IEF72022430 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 9 Apr 2010 14:14:15 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o39IEENa028464; 	Fri, 9 Apr 2010 14:14:15 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o39IEDEs004939; 	Fri, 9 Apr 2010 14:14:14 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 83D6E379786; Fri,  9 Apr 2010 12:14:13 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: crquan@gmail.com
Cc: gdb-patches@sourceware.org, Hui Zhu <teawater@gmail.com>,         Joel Brobecker <brobecker@adacore.com>, Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] disassemble support start,+length format
References: <1270786615-29934-1-git-send-email-crquan@gmail.com>
Reply-To: tromey@redhat.com
Date: Fri, 09 Apr 2010 18:14:00 -0000
In-Reply-To: <1270786615-29934-1-git-send-email-crquan@gmail.com> 	(crquan@gmail.com's message of "Fri, 9 Apr 2010 12:16:55 +0800")
Message-ID: <m3vdc0jxxm.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00272.txt.bz2

>>>>> ">" == crquan  <crquan@gmail.com> writes:

>> From: CHENG Renquan <rqcheng@smu.edu.sg>
>> add new support for disassemble by "start,+length" format;

Do you have a copyright assignment in place?
If not, let me know and I can get you started.

>>        /* Two arguments.  */
>> +      int incl_flag = 0;
>> +
>>        low = pc;

I think you should skip whitespace here.

>> +      if (arg[0] == '+') {

The brace placement is wrong here.  See the GNU Coding Standards, or
existing code in that function.

Otherwise this seems reasonable to me.

Tom