Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: implement ambiguous linespec proposal
Date: Tue, 01 Nov 2011 20:58:00 -0000	[thread overview]
Message-ID: <m3ty6nzhkk.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20111028221459.GA28467@host1.jankratochvil.net> (Jan	Kratochvil's message of "Sat, 29 Oct 2011 00:14:59 +0200")

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> -PASS: gdb.base/step-line.exp: break f1
Jan> +FAIL: gdb.base/step-line.exp: break f1

This fails because there is a (data) symbol named 'f1' in libm.
I think 'break' and friends will have to pass in a flag meaning "only
look for text symbols".

Jan> -PASS: gdb.cp/ovsrch.exp: break outer::foo if (a == 3)
Jan> +FAIL: gdb.cp/ovsrch.exp: break outer::foo if (a == 3)
Jan> -PASS: gdb.cp/ovsrch.exp: break inner::foo if (a == 3)
Jan> +FAIL: gdb.cp/ovsrch.exp: break inner::foo if (a == 3)

I don't like how this test assumes that gdb will do a namespace search
for a symbol when decoding linespecs.  That just seems wrong to me.
But, we've shipped it for a while, so I think we'll have to cope.

I think I will need a new language method to handle this properly.

The test itself is bogus since it makes an assumption about which
overload 'inner::foo' will match.  I think it should match all of them,
and in one of them there is no symbol named 'a'.

Jan> Just on Fedora 16 x86_64 with -m32:
Jan> -PASS: gdb.threads/thread_check.exp: breakpoint at tf
Jan> +FAIL: gdb.threads/thread_check.exp: breakpoint at tf

Similar to step-line, 'tf' is a .bss symbol in libc.

Tom


  reply	other threads:[~2011-11-01 20:58 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 17:34 Tom Tromey
2011-10-28 20:52 ` Matt Rice
2011-11-01 20:38   ` Tom Tromey
2011-10-28 22:41 ` Jan Kratochvil
2011-11-01 20:58   ` Tom Tromey [this message]
2011-11-03 20:49     ` Tom Tromey
2011-11-04  7:46       ` Jan Kratochvil
2011-11-08 16:36         ` Tom Tromey
2011-11-09 16:05           ` Joel Brobecker
2011-11-09 17:12             ` Tom Tromey
2011-11-09 17:56               ` Joel Brobecker
2011-11-09 18:19                 ` Tom Tromey
2011-11-09 19:00                   ` Joel Brobecker
2011-11-14 21:04                     ` Tom Tromey
2011-11-14 21:32                       ` Jerome Guitton
2011-11-09 18:37           ` Tom Tromey
2011-11-14 21:11             ` Tom Tromey
2011-11-15 16:30               ` Tom Tromey
2011-11-15 16:59                 ` Pierre Muller
2011-11-16  0:09                 ` Jan Kratochvil
2011-11-16  1:58                   ` Joel Brobecker
2011-11-16 14:46                   ` Tom Tromey
2011-11-18 14:10                     ` Tom Tromey
2011-11-16 21:23                 ` Stan Shebs
2011-11-16  2:28               ` Yao Qi
2011-11-16  3:20                 ` Doug Evans
2011-11-16 14:46                 ` Tom Tromey
2011-11-16 16:06                   ` Tom Tromey
2011-11-16  4:57               ` Doug Evans
2011-11-16  5:22                 ` Doug Evans
2011-11-16 14:54                   ` Tom Tromey
2011-11-16 16:32                     ` Doug Evans
2011-11-16 16:39                       ` Tom Tromey
2011-11-16 14:49                 ` Tom Tromey
2011-11-16  8:15               ` Yao Qi
2011-11-16 16:17                 ` Tom Tromey
2011-11-16 15:43               ` Yao Qi
2011-11-16 16:11                 ` Tom Tromey
2011-11-16 16:44                   ` Tom Tromey
2011-11-17  3:49                     ` Yao Qi
2011-11-21 21:50                       ` Tom Tromey
2011-11-23 21:33               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ty6nzhkk.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox