From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18705 invoked by alias); 1 Nov 2011 20:58:10 -0000 Received: (qmail 18686 invoked by uid 22791); 1 Nov 2011 20:58:09 -0000 X-SWARE-Spam-Status: No, hits=-7.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 01 Nov 2011 20:57:49 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id pA1KvmFg014533 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 1 Nov 2011 16:57:48 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id pA1KvmCa009827; Tue, 1 Nov 2011 16:57:48 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id pA1KvlXb030164; Tue, 1 Nov 2011 16:57:47 -0400 From: Tom Tromey To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: RFA: implement ambiguous linespec proposal References: <20111028221459.GA28467@host1.jankratochvil.net> Date: Tue, 01 Nov 2011 20:58:00 -0000 In-Reply-To: <20111028221459.GA28467@host1.jankratochvil.net> (Jan Kratochvil's message of "Sat, 29 Oct 2011 00:14:59 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-11/txt/msg00031.txt.bz2 >>>>> "Jan" == Jan Kratochvil writes: Jan> -PASS: gdb.base/step-line.exp: break f1 Jan> +FAIL: gdb.base/step-line.exp: break f1 This fails because there is a (data) symbol named 'f1' in libm. I think 'break' and friends will have to pass in a flag meaning "only look for text symbols". Jan> -PASS: gdb.cp/ovsrch.exp: break outer::foo if (a == 3) Jan> +FAIL: gdb.cp/ovsrch.exp: break outer::foo if (a == 3) Jan> -PASS: gdb.cp/ovsrch.exp: break inner::foo if (a == 3) Jan> +FAIL: gdb.cp/ovsrch.exp: break inner::foo if (a == 3) I don't like how this test assumes that gdb will do a namespace search for a symbol when decoding linespecs. That just seems wrong to me. But, we've shipped it for a while, so I think we'll have to cope. I think I will need a new language method to handle this properly. The test itself is bogus since it makes an assumption about which overload 'inner::foo' will match. I think it should match all of them, and in one of them there is no symbol named 'a'. Jan> Just on Fedora 16 x86_64 with -m32: Jan> -PASS: gdb.threads/thread_check.exp: breakpoint at tf Jan> +FAIL: gdb.threads/thread_check.exp: breakpoint at tf Similar to step-line, 'tf' is a .bss symbol in libc. Tom