Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>, Jerome Guitton <guitton@adacore.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: RFA: implement ambiguous linespec proposal
Date: Wed, 09 Nov 2011 16:05:00 -0000	[thread overview]
Message-ID: <20111109160529.GO14508@adacore.com> (raw)
In-Reply-To: <m339dyk1v6.fsf@fleche.redhat.com>

> I think it would also make some Ada cases work more sanely, though I
> don't know enough to say with certainty.  I'm thinking here about how
> ada_lookup_symbol_list returns a list but then the linespec code only
> uses the first one (via some call through ada_lookup_encoded_symbol, I
> don't remember the details).

You are missing part of the picture, I think, because some of our code
is not in the FSF tree [1]. We get multiple breakpoints for situations
such as homonyms, or generics (aka templates in C++) instantiations.
In that situation, I think that the FSF GDB only picks the first one,
whereas AdaCore's GDB creates multiple breakpoints.

> My problem with this is that it adds more complexity to the user
> interface: some linespecs will create a single breakpoint with multiple
> locations, some will create multiple breakpoints once again, depending
> on the context.

We have a similar issue: When the user inserts a breakpoint, and there
are multiple possible choices, we have two scnearios:
  1. He selects `all' -> In that case, we actually create one breakpoint
     with multiple locations;
  2. He selects a subset -> In that situation, we create one breakpoint
     per location.

I think this can be pretty confusing.

I am copying Jerome Guitton on this message, since he did the work
for that.

-- 
Joel

[1]: We tried contributing it, but it was too hacky to really be part
     of the FSF sources. The main complaint at the time was the fact
     that it introduced a canonical form that was specific to Ada. I was
     planning on looking at generalizing it to all languages, but never
     got around to doing it.


  reply	other threads:[~2011-11-09 16:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-28 17:34 Tom Tromey
2011-10-28 20:52 ` Matt Rice
2011-11-01 20:38   ` Tom Tromey
2011-10-28 22:41 ` Jan Kratochvil
2011-11-01 20:58   ` Tom Tromey
2011-11-03 20:49     ` Tom Tromey
2011-11-04  7:46       ` Jan Kratochvil
2011-11-08 16:36         ` Tom Tromey
2011-11-09 16:05           ` Joel Brobecker [this message]
2011-11-09 17:12             ` Tom Tromey
2011-11-09 17:56               ` Joel Brobecker
2011-11-09 18:19                 ` Tom Tromey
2011-11-09 19:00                   ` Joel Brobecker
2011-11-14 21:04                     ` Tom Tromey
2011-11-14 21:32                       ` Jerome Guitton
2011-11-09 18:37           ` Tom Tromey
2011-11-14 21:11             ` Tom Tromey
2011-11-15 16:30               ` Tom Tromey
2011-11-15 16:59                 ` Pierre Muller
2011-11-16  0:09                 ` Jan Kratochvil
2011-11-16  1:58                   ` Joel Brobecker
2011-11-16 14:46                   ` Tom Tromey
2011-11-18 14:10                     ` Tom Tromey
2011-11-16 21:23                 ` Stan Shebs
2011-11-16  2:28               ` Yao Qi
2011-11-16  3:20                 ` Doug Evans
2011-11-16 14:46                 ` Tom Tromey
2011-11-16 16:06                   ` Tom Tromey
2011-11-16  4:57               ` Doug Evans
2011-11-16  5:22                 ` Doug Evans
2011-11-16 14:54                   ` Tom Tromey
2011-11-16 16:32                     ` Doug Evans
2011-11-16 16:39                       ` Tom Tromey
2011-11-16 14:49                 ` Tom Tromey
2011-11-16  8:15               ` Yao Qi
2011-11-16 16:17                 ` Tom Tromey
2011-11-16 15:43               ` Yao Qi
2011-11-16 16:11                 ` Tom Tromey
2011-11-16 16:44                   ` Tom Tromey
2011-11-17  3:49                     ` Yao Qi
2011-11-21 21:50                       ` Tom Tromey
2011-11-23 21:33               ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111109160529.GO14508@adacore.com \
    --to=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    --cc=jan.kratochvil@redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox