FYI: add TAGS target in testsuite

FYI: add TAGS target in testsuite

[Tom Tromey]

I am checking this in.

I wanted to be able to use tags in the testsuite.  This patch adds a
"TAGS" target to the testsuite Makefile.

I am undecided as to whether I should add this to gdb/TAGS via `etags
--include'.  If you use etags, and have an opinion, let me know.

Tom

2011-03-07  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (TAGS): New target.

diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
index c1356c5..8017ff0 100644
--- a/gdb/testsuite/Makefile.in
+++ b/gdb/testsuite/Makefile.in
@@ -242,3 +242,7 @@ Makefile : Makefile.in config.status $(host_makefile_frag)
 
 config.status: configure
 	$(SHELL) config.status --recheck
+
+TAGS: force
+	etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
+	  `find $(srcdir) -name '*.exp' -print`

RE: add TAGS target in testsuite

[Pierre Muller]

  I wanted to try this out, but
I got this:

Pierre@E6510-Muller ~/gdbcvs/build-norm/gdb/testsuite
$ etags --version
Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert
  Compiled: Dec 11 2009, 11:42:40
  Addresses: <dhiebert@users.sourceforge.net>, http://ctags.sourceforge.net
  Optional compiled features: +wildcards, +regex, +internal-sort

Pierre@E6510-Muller ~/gdbcvs/build-norm/gdb/testsuite
$ make TAGS
etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
          `find ../../../src/gdb/testsuite -name '*.exp' -print`
etags: Warning: "--language" option is obsolete; use "--language-force"
instead
etags: Unknown language "none" in "language" option
make: *** [TAGS] Error 1


Pierre

> -----Message d'origine-----
> De : gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] De la part de Tom Tromey
> Envoyé : lundi 7 mars 2011 18:04
> À : gdb-patches@sourceware.org
> Objet : FYI: add TAGS target in testsuite
> 
> I am checking this in.
> 
> I wanted to be able to use tags in the testsuite.  This patch adds a
> "TAGS" target to the testsuite Makefile.
> 
> I am undecided as to whether I should add this to gdb/TAGS via `etags
> --include'.  If you use etags, and have an opinion, let me know.
> 
> Tom
> 
> 2011-03-07  Tom Tromey  <tromey@redhat.com>
> 
> 	* Makefile.in (TAGS): New target.
> 
> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
> index c1356c5..8017ff0 100644
> --- a/gdb/testsuite/Makefile.in
> +++ b/gdb/testsuite/Makefile.in
> @@ -242,3 +242,7 @@ Makefile : Makefile.in config.status
> $(host_makefile_frag)
> 
>  config.status: configure
>  	$(SHELL) config.status --recheck
> +
> +TAGS: force
> +	etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
> +	  `find $(srcdir) -name '*.exp' -print`

Re: add TAGS target in testsuite

[Tom Tromey]

>>>>> "Pierre" == Pierre Muller <pierre.muller@ics-cnrs.unistra.fr> writes:

Pierre> $ etags --version
Pierre> Exuberant Ctags 5.8, Copyright (C) 1996-2009 Darren Hiebert

You need the "real" etags, not this one.

Pierre> etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
Pierre>           `find ../../../src/gdb/testsuite -name '*.exp' -print`
Pierre> etags: Warning: "--language" option is obsolete; use "--language-force"
Pierre> instead
Pierre> etags: Unknown language "none" in "language" option

I think that the Emacs etags defines the etags interface.
If Exuberant Ctags is incompatible, then that is their bug.

I suppose one could write configury for this, but it seems like more
trouble than it is worth to me.

If you prefer, I can revert this patch.

Tom

Re: add TAGS target in testsuite

[Eli Zaretskii]

> From: Tom Tromey <tromey@redhat.com>
> Cc: <gdb-patches@sourceware.org>
> Date: Mon, 07 Mar 2011 10:24:21 -0700
> 
> Pierre> etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
> Pierre>           `find ../../../src/gdb/testsuite -name '*.exp' -print`
> Pierre> etags: Warning: "--language" option is obsolete; use "--language-force"
> Pierre> instead
> Pierre> etags: Unknown language "none" in "language" option
> 
> I think that the Emacs etags defines the etags interface.
> If Exuberant Ctags is incompatible, then that is their bug.

Do bad things happen if you don't specify --language=none?

> I suppose one could write configury for this, but it seems like more
> trouble than it is worth to me.
> 
> If you prefer, I can revert this patch.

I don't think this is reason good enough to revert the patch.

However, wouldn't "find ... | etags ... -" be slightly better?

Re: add TAGS target in testsuite

[Tom Tromey]

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> Do bad things happen if you don't specify --language=none?

Nope.

Eli> However, wouldn't "find ... | etags ... -" be slightly better?

Sure.

Eli> IMO, it only makes sense to add this to gdb/TAGS if the additional
Eli> tags get into the GDB binary.  The test suite does not satisfy this
Eli> requirement (unlike, say, portions of Emacs implemented in Lisp).

Ok.

Michael> I use etags.  My preference would be not to.

Ok.

Here is what I am checking in.
Pierre, maybe this will work better for you; I don't know.

Tom

2011-03-07  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (TAGS): Rewrite.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v
retrieving revision 1.38
diff -u -r1.38 Makefile.in
--- Makefile.in	7 Mar 2011 17:03:51 -0000	1.38
+++ Makefile.in	7 Mar 2011 22:00:51 -0000
@@ -245,5 +245,5 @@
 	$(SHELL) config.status --recheck
 
 TAGS: force
-	etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
-	  `find $(srcdir) -name '*.exp' -print`
+	find $(srcdir) -name '*.exp' -print | \
+	    etags --regex='/proc[ \t]+\([^ \t]+\)/\1/' -

Re: FYI: add TAGS target in testsuite

[Eli Zaretskii]

> From: Tom Tromey <tromey@redhat.com>
> Date: Mon, 07 Mar 2011 10:03:38 -0700
> 
> I am undecided as to whether I should add this to gdb/TAGS via `etags
> --include'.  If you use etags, and have an opinion, let me know.

IMO, it only makes sense to add this to gdb/TAGS if the additional
tags get into the GDB binary.  The test suite does not satisfy this
requirement (unlike, say, portions of Emacs implemented in Lisp).

TAGS tables are used when you develop a package and need to quickly
find the implementation of certain functionalities of that package.
Anything that is not part of the package functionality should be on a
separate TAGS file.

Re: FYI: add TAGS target in testsuite

[Michael Snyder]

Tom Tromey wrote:
> I am checking this in.
> 
> I wanted to be able to use tags in the testsuite.  This patch adds a
> "TAGS" target to the testsuite Makefile.
> 
> I am undecided as to whether I should add this to gdb/TAGS via `etags
> --include'.  If you use etags, and have an opinion, let me know.

I use etags.  My preference would be not to.  These test files aren't
part of gdb.

> 2011-03-07  Tom Tromey  <tromey@redhat.com>
> 
> 	* Makefile.in (TAGS): New target.
> 
> diff --git a/gdb/testsuite/Makefile.in b/gdb/testsuite/Makefile.in
> index c1356c5..8017ff0 100644
> --- a/gdb/testsuite/Makefile.in
> +++ b/gdb/testsuite/Makefile.in
> @@ -242,3 +242,7 @@ Makefile : Makefile.in config.status $(host_makefile_frag)
>  
>  config.status: configure
>  	$(SHELL) config.status --recheck
> +
> +TAGS: force
> +	etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
> +	  `find $(srcdir) -name '*.exp' -print`