Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org
Subject: Re: add TAGS target in testsuite
Date: Tue, 08 Mar 2011 01:11:00 -0000	[thread overview]
Message-ID: <m3ipvuk2t5.fsf@fleche.redhat.com> (raw)
In-Reply-To: <83k4gahkxr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar	2011 19:58:24 +0200")

>>>>> "Eli" == Eli Zaretskii <eliz@gnu.org> writes:

Eli> Do bad things happen if you don't specify --language=none?

Nope.

Eli> However, wouldn't "find ... | etags ... -" be slightly better?

Sure.

Eli> IMO, it only makes sense to add this to gdb/TAGS if the additional
Eli> tags get into the GDB binary.  The test suite does not satisfy this
Eli> requirement (unlike, say, portions of Emacs implemented in Lisp).

Ok.

Michael> I use etags.  My preference would be not to.

Ok.

Here is what I am checking in.
Pierre, maybe this will work better for you; I don't know.

Tom

2011-03-07  Tom Tromey  <tromey@redhat.com>

	* Makefile.in (TAGS): Rewrite.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v
retrieving revision 1.38
diff -u -r1.38 Makefile.in
--- Makefile.in	7 Mar 2011 17:03:51 -0000	1.38
+++ Makefile.in	7 Mar 2011 22:00:51 -0000
@@ -245,5 +245,5 @@
 	$(SHELL) config.status --recheck
 
 TAGS: force
-	etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \
-	  `find $(srcdir) -name '*.exp' -print`
+	find $(srcdir) -name '*.exp' -print | \
+	    etags --regex='/proc[ \t]+\([^ \t]+\)/\1/' -


  reply	other threads:[~2011-03-07 22:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-07 17:24 FYI: " Tom Tromey
2011-03-07 18:00 ` Pierre Muller
     [not found] ` <21165.0532474325$1299518488@news.gmane.org>
2011-03-07 18:06   ` Tom Tromey
2011-03-07 18:42     ` Eli Zaretskii
2011-03-08  1:11       ` Tom Tromey [this message]
2011-03-07 18:43 ` FYI: " Eli Zaretskii
2011-03-07 20:10 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3ipvuk2t5.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox