From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24167 invoked by alias); 7 Mar 2011 22:01:58 -0000 Received: (qmail 24159 invoked by uid 22791); 7 Mar 2011 22:01:57 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Mar 2011 22:01:51 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p27M1iKn014862 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 7 Mar 2011 17:01:45 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p27M1h15029322; Mon, 7 Mar 2011 17:01:44 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p27M1gas027735; Mon, 7 Mar 2011 17:01:43 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 98345378339; Mon, 7 Mar 2011 15:01:42 -0700 (MST) From: Tom Tromey To: Eli Zaretskii Cc: pierre.muller@ics-cnrs.unistra.fr, gdb-patches@sourceware.org Subject: Re: add TAGS target in testsuite References: <21165.0532474325$1299518488@news.gmane.org> <83k4gahkxr.fsf@gnu.org> Date: Tue, 08 Mar 2011 01:11:00 -0000 In-Reply-To: <83k4gahkxr.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 07 Mar 2011 19:58:24 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-03/txt/msg00509.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: Eli> Do bad things happen if you don't specify --language=none? Nope. Eli> However, wouldn't "find ... | etags ... -" be slightly better? Sure. Eli> IMO, it only makes sense to add this to gdb/TAGS if the additional Eli> tags get into the GDB binary. The test suite does not satisfy this Eli> requirement (unlike, say, portions of Emacs implemented in Lisp). Ok. Michael> I use etags. My preference would be not to. Ok. Here is what I am checking in. Pierre, maybe this will work better for you; I don't know. Tom 2011-03-07 Tom Tromey * Makefile.in (TAGS): Rewrite. Index: Makefile.in =================================================================== RCS file: /cvs/src/src/gdb/testsuite/Makefile.in,v retrieving revision 1.38 diff -u -r1.38 Makefile.in --- Makefile.in 7 Mar 2011 17:03:51 -0000 1.38 +++ Makefile.in 7 Mar 2011 22:00:51 -0000 @@ -245,5 +245,5 @@ $(SHELL) config.status --recheck TAGS: force - etags --language=none --regex='/proc[ \t]+\([^ \t]+\)/\1/' \ - `find $(srcdir) -name '*.exp' -print` + find $(srcdir) -name '*.exp' -print | \ + etags --regex='/proc[ \t]+\([^ \t]+\)/\1/' -