From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
Date: Fri, 20 Nov 2009 17:28:00 -0000 [thread overview]
Message-ID: <m3pr7d9ket.fsf@fleche.redhat.com> (raw)
In-Reply-To: <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> (Paul Pluzhnikov's message of "Thu, 19 Nov 2009 15:39:43 -0800")
>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:
Paul> It works, but I can't make it backward-compatible and not require a comma
Paul> for two-argument invocation :-(
Yeah.
Paul> If it's acceptable to require comma for two-argument command
Paul> (which IMO it is), I'll update documentation and testsuites, and
Paul> produce a "real" patch.
It is fine by me.
If anybody objects it would be helpful if they would speak up sooner
rather than later.
Paul> + if (arg[0] == ',')
Paul> + ++arg;
Paul> + if (arg[0] == '\0')
You probably want to skip whitespace after the ",".
Tom
next prev parent reply other threads:[~2009-11-20 17:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 0:10 Paul Pluzhnikov
2009-11-15 8:54 ` Andreas Schwab
2009-11-15 17:17 ` Paul Pluzhnikov
2009-11-15 17:26 ` Daniel Jacobowitz
2009-11-16 18:26 ` Tom Tromey
2009-11-16 18:29 ` Paul Pluzhnikov
2009-11-19 23:41 ` Paul Pluzhnikov
2009-11-20 17:28 ` Tom Tromey [this message]
2009-11-20 17:41 ` Paul Pluzhnikov
2009-11-21 0:44 ` Paul Pluzhnikov
2009-11-21 1:00 ` Daniel Jacobowitz
2009-11-21 1:09 ` Paul Pluzhnikov
2009-11-21 8:36 ` Eli Zaretskii
2009-11-22 2:40 ` Paul Pluzhnikov
2009-11-22 4:28 ` Eli Zaretskii
2009-11-23 7:45 ` Paul Pluzhnikov
2009-11-23 11:58 ` Eli Zaretskii
2009-11-23 17:42 ` Paul Pluzhnikov
2009-11-23 18:40 ` Eli Zaretskii
2009-11-23 17:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3pr7d9ket.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox