From: Andreas Schwab <schwab@linux-m68k.org>
To: ppluzhnikov@google.com (Paul Pluzhnikov)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
Date: Sun, 15 Nov 2009 08:54:00 -0000 [thread overview]
Message-ID: <m23a4g5fur.fsf@whitebox.home> (raw)
In-Reply-To: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> (Paul Pluzhnikov's message of "Fri, 13 Nov 2009 16:10:22 -0800 (PST)")
ppluzhnikov@google.com (Paul Pluzhnikov) writes:
> Index: cli/cli-cmds.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
> retrieving revision 1.93
> diff -u -p -u -r1.93 cli-cmds.c
> --- cli/cli-cmds.c 23 Oct 2009 00:49:33 -0000 1.93
> +++ cli/cli-cmds.c 13 Nov 2009 23:59:08 -0000
> @@ -1025,7 +1025,8 @@ disassemble_command (char *arg, int from
> /* FIXME: 'twould be nice to allow spaces in the expression for the first
> arg. Allow comma separater too? */
>
> - if (!(space_index = (char *) strchr (arg, ' ')))
> + space_index = skip_quoted (arg);
> + if (!(space_index = (char *) strchr (space_index, ' ')))
Looks like the comment is now obsolete?
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2009-11-15 8:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 0:10 Paul Pluzhnikov
2009-11-15 8:54 ` Andreas Schwab [this message]
2009-11-15 17:17 ` Paul Pluzhnikov
2009-11-15 17:26 ` Daniel Jacobowitz
2009-11-16 18:26 ` Tom Tromey
2009-11-16 18:29 ` Paul Pluzhnikov
2009-11-19 23:41 ` Paul Pluzhnikov
2009-11-20 17:28 ` Tom Tromey
2009-11-20 17:41 ` Paul Pluzhnikov
2009-11-21 0:44 ` Paul Pluzhnikov
2009-11-21 1:00 ` Daniel Jacobowitz
2009-11-21 1:09 ` Paul Pluzhnikov
2009-11-21 8:36 ` Eli Zaretskii
2009-11-22 2:40 ` Paul Pluzhnikov
2009-11-22 4:28 ` Eli Zaretskii
2009-11-23 7:45 ` Paul Pluzhnikov
2009-11-23 11:58 ` Eli Zaretskii
2009-11-23 17:42 ` Paul Pluzhnikov
2009-11-23 18:40 ` Eli Zaretskii
2009-11-23 17:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m23a4g5fur.fsf@whitebox.home \
--to=schwab@linux-m68k.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox