From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68424-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 25476 invoked by alias); 15 Nov 2009 08:54:51 -0000
Received: (qmail 25465 invoked by uid 22791); 15 Nov 2009 08:54:49 -0000
X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 	tests=AWL,BAYES_00
X-Spam-Check-By: sourceware.org
Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.10)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 Nov 2009 08:53:20 +0000
Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) 	by mail-out.m-online.net (Postfix) with ESMTP id A6BA81C00D43; 	Sun, 15 Nov 2009 09:53:17 +0100 (CET)
X-Auth-Info: vPOpbXFd/HD6u8WSOg9YMeUfoOQ/D9YNVfm1BSNYIIk=
Received: from whitebox.home (DSL01.83.171.147.50.ip-pool.NEFkom.net [83.171.147.50]) 	by mail.mnet-online.de (Postfix) with ESMTP id 357EA9008C; 	Sun, 15 Nov 2009 09:53:17 +0100 (CET)
Received: by whitebox.home (Postfix, from userid 501) 	id 6D5C91E5374; Sun, 15 Nov 2009 09:53:17 +0100 (CET)
From: Andreas Schwab <schwab@linux-m68k.org>
To: ppluzhnikov@google.com (Paul Pluzhnikov)
Cc: gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com>
X-Yow: Sign my PETITION.
Date: Sun, 15 Nov 2009 08:54:00 -0000
In-Reply-To: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> (Paul 	Pluzhnikov's message of "Fri, 13 Nov 2009 16:10:22 -0800 (PST)")
Message-ID: <m23a4g5fur.fsf@whitebox.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00331.txt.bz2

ppluzhnikov@google.com (Paul Pluzhnikov) writes:

> Index: cli/cli-cmds.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/cli/cli-cmds.c,v
> retrieving revision 1.93
> diff -u -p -u -r1.93 cli-cmds.c
> --- cli/cli-cmds.c	23 Oct 2009 00:49:33 -0000	1.93
> +++ cli/cli-cmds.c	13 Nov 2009 23:59:08 -0000
> @@ -1025,7 +1025,8 @@ disassemble_command (char *arg, int from
>    /* FIXME: 'twould be nice to allow spaces in the expression for the first
>       arg.  Allow comma separater too?  */
>  
> -  if (!(space_index = (char *) strchr (arg, ' ')))
> +  space_index = skip_quoted (arg);
> +  if (!(space_index = (char *) strchr (space_index, ' ')))

Looks like the comment is now obsolete?

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."