Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, schwab@linux-m68k.org, gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
Date: Sat, 21 Nov 2009 08:36:00 -0000	[thread overview]
Message-ID: <83lji0p96p.fsf@gnu.org> (raw)
In-Reply-To: <8ac60eac0911201708k2c9bc062w9c34765e03b83566@mail.gmail.com>

> Date: Fri, 20 Nov 2009 17:08:21 -0800
> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> 
> On Fri, Nov 20, 2009 at 4:59 PM, Daniel Jacobowitz <drow@false.org> wrote:
> 
> >> Does this require a NEWS entry (incompatible change to disassemble
> >> command) ?
> >
> > I think yes.
> 
> Thanks, NEWS mention added.

Thanks.  I have only one comment: You say everywhere in the docs that
the 2 arguments should be "separated by comma".  ("Separated by a
comma" would be more correct, English-wise.)  However, the test files
show that the arguments can in fact be separated by a combination of a
comma and whitespace:

> -test_dis "disassem &staticvar &staticvar+1" "staticvar"
> +test_dis "disassem &staticvar, &staticvar+1" "staticvar"

Is my interpretation of the test correct?  If it is, then the
documentation should say that whitespace is allowed around the comma.


  reply	other threads:[~2009-11-21  8:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14  0:10 Paul Pluzhnikov
2009-11-15  8:54 ` Andreas Schwab
2009-11-15 17:17   ` Paul Pluzhnikov
2009-11-15 17:26     ` Daniel Jacobowitz
2009-11-16 18:26     ` Tom Tromey
2009-11-16 18:29       ` Paul Pluzhnikov
2009-11-19 23:41         ` Paul Pluzhnikov
2009-11-20 17:28           ` Tom Tromey
2009-11-20 17:41             ` Paul Pluzhnikov
2009-11-21  0:44             ` Paul Pluzhnikov
2009-11-21  1:00               ` Daniel Jacobowitz
2009-11-21  1:09                 ` Paul Pluzhnikov
2009-11-21  8:36                   ` Eli Zaretskii [this message]
2009-11-22  2:40                     ` Paul Pluzhnikov
2009-11-22  4:28                       ` Eli Zaretskii
2009-11-23  7:45                         ` Paul Pluzhnikov
2009-11-23 11:58                           ` Eli Zaretskii
2009-11-23 17:42                             ` Paul Pluzhnikov
2009-11-23 18:40                               ` Eli Zaretskii
2009-11-23 17:30                       ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83lji0p96p.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=ppluzhnikov@google.com \
    --cc=schwab@linux-m68k.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox