From: Daniel Jacobowitz <drow@false.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
Date: Sun, 15 Nov 2009 17:26:00 -0000 [thread overview]
Message-ID: <20091115172510.GA23483@caradoc.them.org> (raw)
In-Reply-To: <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com>
On Sun, Nov 15, 2009 at 09:16:06AM -0800, Paul Pluzhnikov wrote:
> The only way I can see to allow general expressions here is to require
> a separator which can't happen in any expression in any language
> (semicolon probably comes close), or for parse_expression() to consume
> as much as it can and set a "end_of_parse" indicator.
>
> But perhaps splitting on comma (after skipping any quoted expression
> -- Foo::bar could have multiple parameters) is "good enough"? That
> would allow 'disas &main + 1, &main + 5' to work.
See parse_to_comma_and_eval (which I always forget about in this
situation...).
It's not perfect, but it does handle parenthesis nesting.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2009-11-15 17:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-14 0:10 Paul Pluzhnikov
2009-11-15 8:54 ` Andreas Schwab
2009-11-15 17:17 ` Paul Pluzhnikov
2009-11-15 17:26 ` Daniel Jacobowitz [this message]
2009-11-16 18:26 ` Tom Tromey
2009-11-16 18:29 ` Paul Pluzhnikov
2009-11-19 23:41 ` Paul Pluzhnikov
2009-11-20 17:28 ` Tom Tromey
2009-11-20 17:41 ` Paul Pluzhnikov
2009-11-21 0:44 ` Paul Pluzhnikov
2009-11-21 1:00 ` Daniel Jacobowitz
2009-11-21 1:09 ` Paul Pluzhnikov
2009-11-21 8:36 ` Eli Zaretskii
2009-11-22 2:40 ` Paul Pluzhnikov
2009-11-22 4:28 ` Eli Zaretskii
2009-11-23 7:45 ` Paul Pluzhnikov
2009-11-23 11:58 ` Eli Zaretskii
2009-11-23 17:42 ` Paul Pluzhnikov
2009-11-23 18:40 ` Eli Zaretskii
2009-11-23 17:30 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091115172510.GA23483@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox