From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68554-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 11925 invoked by alias); 21 Nov 2009 08:36:26 -0000
Received: (qmail 11916 invoked by uid 22791); 21 Nov 2009 08:36:26 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 	tests=AWL,BAYES_00,SPF_SOFTFAIL
X-Spam-Check-By: sourceware.org
Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 Nov 2009 08:35:13 +0000
Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0KTG00000A7R4400@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Sat, 21 Nov 2009 10:35:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.70.37.193]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0KTG00MKCAILFB30@a-mtaout20.012.net.il>; Sat, 21 Nov 2009 10:35:10 +0200 (IST)
Date: Sat, 21 Nov 2009 08:36:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
In-reply-to: <8ac60eac0911201708k2c9bc062w9c34765e03b83566@mail.gmail.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, schwab@linux-m68k.org, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83lji0p96p.fsf@gnu.org>
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> <m23a4g5fur.fsf@whitebox.home> <8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> <m3my2mtjhp.fsf@fleche.redhat.com> <8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> <m3pr7d9ket.fsf@fleche.redhat.com> <8ac60eac0911201642y138489ffvab73550bfa72a89d@mail.gmail.com> <20091121005931.GA24143@caradoc.them.org> <8ac60eac0911201708k2c9bc062w9c34765e03b83566@mail.gmail.com>
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00461.txt.bz2

> Date: Fri, 20 Nov 2009 17:08:21 -0800
> From: Paul Pluzhnikov <ppluzhnikov@google.com>
> 
> On Fri, Nov 20, 2009 at 4:59 PM, Daniel Jacobowitz <drow@false.org> wrote:
> 
> >> Does this require a NEWS entry (incompatible change to disassemble
> >> command) ?
> >
> > I think yes.
> 
> Thanks, NEWS mention added.

Thanks.  I have only one comment: You say everywhere in the docs that
the 2 arguments should be "separated by comma".  ("Separated by a
comma" would be more correct, English-wise.)  However, the test files
show that the arguments can in fact be separated by a combination of a
comma and whitespace:

> -test_dis "disassem &staticvar &staticvar+1" "staticvar"
> +test_dis "disassem &staticvar, &staticvar+1" "staticvar"

Is my interpretation of the test correct?  If it is, then the
documentation should say that whitespace is allowed around the comma.