From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-68534-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19679 invoked by alias); 20 Nov 2009 17:28:28 -0000
Received: (qmail 19671 invoked by uid 22791); 20 Nov 2009 17:28:28 -0000
X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 	tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 20 Nov 2009 17:27:24 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) 	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id nAKHR8WF026616 	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); 	Fri, 20 Nov 2009 12:27:08 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) 	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id nAKHR7vb018468; 	Fri, 20 Nov 2009 12:27:08 -0500
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) 	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id nAKHR6WB024674; 	Fri, 20 Nov 2009 12:27:07 -0500
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 9A1488884B7; Fri, 20 Nov 2009 10:27:06 -0700 (MST)
From: Tom Tromey <tromey@redhat.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: Andreas Schwab <schwab@linux-m68k.org>, gdb-patches@sourceware.org
Subject: Re: [patch] Allow "disassemble 'Foo::bar(char *)'"
References: <20091114001022.A0A0776CDD@ppluzhnikov.mtv.corp.google.com> 	<m23a4g5fur.fsf@whitebox.home> 	<8ac60eac0911150916k70ac0f62hf349b0bc21aa58b7@mail.gmail.com> 	<m3my2mtjhp.fsf@fleche.redhat.com> 	<8ac60eac0911161028of5f2352lf1857db7a46a94b2@mail.gmail.com> 	<8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com>
Reply-To: Tom Tromey <tromey@redhat.com>
Date: Fri, 20 Nov 2009 17:28:00 -0000
In-Reply-To: <8ac60eac0911191539w4245739ka6405ba072b79395@mail.gmail.com> 	(Paul Pluzhnikov's message of "Thu, 19 Nov 2009 15:39:43 -0800")
Message-ID: <m3pr7d9ket.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-11/txt/msg00441.txt.bz2

>>>>> "Paul" == Paul Pluzhnikov <ppluzhnikov@google.com> writes:

Paul> It works, but I can't make it backward-compatible and not require a comma
Paul> for two-argument invocation :-(

Yeah.

Paul> If it's acceptable to require comma for two-argument command
Paul> (which IMO it is), I'll update documentation and testsuites, and
Paul> produce a "real" patch.

It is fine by me.

If anybody objects it would be helpful if they would speak up sooner
rather than later.

Paul> +  if (arg[0] == ',')
Paul> +    ++arg;
Paul> +  if (arg[0] == '\0')

You probably want to skip whitespace after the ",".

Tom