[PATCH] Check skip_cplus_tests for gdb.python/py-template.exp

[PATCH] Check skip_cplus_tests for gdb.python/py-template.exp

[Andrew Burgess]

The test gdb.python/py-template.exp compiles a c++ test, if feels like 
we shouldn't be attempting this if the skip_cplus_test function returns 
true.

The patch is below, OK to apply? As this seems fairly obvious I'll apply 
in a few days unless someone asks me not too.

Cheers,

Andrew

gdb/testsuite/ChangeLog

2011-06-29  Andrew Burgess  <aburgess@broadcom.com>

	* gdb.python/py-template.exp: Don't run this test if the target
	does not support c++ tests.

diff --git a/gdb/testsuite/gdb.python/py-template.exp 
b/gdb/testsuite/gdb.python/py-template.exp
index d22e4d1..9656831 100644
--- a/gdb/testsuite/gdb.python/py-template.exp
+++ b/gdb/testsuite/gdb.python/py-template.exp
@@ -20,6 +20,8 @@ if $tracelevel then {
      strace $tracelevel
  }

+if { [skip_cplus_tests] } { continue }
+
  set testfile "py-template"
  set srcfile ${testfile}.cc
  set binfile ${objdir}/${subdir}/${testfile}

Re: [PATCH] Check skip_cplus_tests for gdb.python/py-template.exp

[Phil Muldoon]

"Andrew Burgess" <aburgess@broadcom.com> writes:

> The test gdb.python/py-template.exp compiles a c++ test, if feels like
> we shouldn't be attempting this if the skip_cplus_test function
> returns true.
>
> The patch is below, OK to apply? As this seems fairly obvious I'll
> apply in a few days unless someone asks me not too.

I cannot give you approval, but it looks fine to me.  I suspect this
falls under the "obvious change" rule, though.

Cheers,

Phil

Re: [PATCH] Check skip_cplus_tests for gdb.python/py-template.exp

[Tom Tromey]

>>>>> "Andrew" == Andrew Burgess <aburgess@broadcom.com> writes:

Andrew> 2011-06-29  Andrew Burgess  <aburgess@broadcom.com>
Andrew> 	* gdb.python/py-template.exp: Don't run this test if the target
Andrew> 	does not support c++ tests.

Ok.

Tom