From: Phil Muldoon <pmuldoon@redhat.com>
To: "Andrew Burgess" <aburgess@broadcom.com>
Cc: "gdb-patches\@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Check skip_cplus_tests for gdb.python/py-template.exp
Date: Wed, 29 Jun 2011 13:36:00 -0000 [thread overview]
Message-ID: <m3liwkn4jp.fsf@redhat.com> (raw)
In-Reply-To: <4E0B18AD.3040100@broadcom.com> (Andrew Burgess's message of "Wed, 29 Jun 2011 13:21:01 +0100")
"Andrew Burgess" <aburgess@broadcom.com> writes:
> The test gdb.python/py-template.exp compiles a c++ test, if feels like
> we shouldn't be attempting this if the skip_cplus_test function
> returns true.
>
> The patch is below, OK to apply? As this seems fairly obvious I'll
> apply in a few days unless someone asks me not too.
I cannot give you approval, but it looks fine to me. I suspect this
falls under the "obvious change" rule, though.
Cheers,
Phil
next prev parent reply other threads:[~2011-06-29 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 12:21 Andrew Burgess
2011-06-29 13:36 ` Phil Muldoon [this message]
2011-06-29 17:32 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3liwkn4jp.fsf@redhat.com \
--to=pmuldoon@redhat.com \
--cc=aburgess@broadcom.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox