Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Andrew Burgess" <aburgess@broadcom.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: [PATCH] Check skip_cplus_tests for gdb.python/py-template.exp
Date: Wed, 29 Jun 2011 12:21:00 -0000	[thread overview]
Message-ID: <4E0B18AD.3040100@broadcom.com> (raw)

The test gdb.python/py-template.exp compiles a c++ test, if feels like 
we shouldn't be attempting this if the skip_cplus_test function returns 
true.

The patch is below, OK to apply? As this seems fairly obvious I'll apply 
in a few days unless someone asks me not too.

Cheers,

Andrew

gdb/testsuite/ChangeLog

2011-06-29  Andrew Burgess  <aburgess@broadcom.com>

	* gdb.python/py-template.exp: Don't run this test if the target
	does not support c++ tests.

diff --git a/gdb/testsuite/gdb.python/py-template.exp 
b/gdb/testsuite/gdb.python/py-template.exp
index d22e4d1..9656831 100644
--- a/gdb/testsuite/gdb.python/py-template.exp
+++ b/gdb/testsuite/gdb.python/py-template.exp
@@ -20,6 +20,8 @@ if $tracelevel then {
      strace $tracelevel
  }

+if { [skip_cplus_tests] } { continue }
+
  set testfile "py-template"
  set srcfile ${testfile}.cc
  set binfile ${objdir}/${subdir}/${testfile}



             reply	other threads:[~2011-06-29 12:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-29 12:21 Andrew Burgess [this message]
2011-06-29 13:36 ` Phil Muldoon
2011-06-29 17:32 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0B18AD.3040100@broadcom.com \
    --to=aburgess@broadcom.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox