From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21262 invoked by alias); 29 Jun 2011 12:21:25 -0000 Received: (qmail 21239 invoked by uid 22791); 29 Jun 2011 12:21:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mms2.broadcom.com (HELO mms2.broadcom.com) (216.31.210.18) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Jun 2011 12:21:10 +0000 Received: from [10.9.200.131] by mms2.broadcom.com with ESMTP (Broadcom SMTP Relay (Email Firewall v6.3.2)); Wed, 29 Jun 2011 05:25:37 -0700 X-Server-Uuid: D3C04415-6FA8-4F2C-93C1-920E106A2031 Received: from mail-irva-13.broadcom.com (10.11.16.103) by IRVEXCHHUB01.corp.ad.broadcom.com (10.9.200.131) with Microsoft SMTP Server id 8.2.247.2; Wed, 29 Jun 2011 05:21:02 -0700 Received: from [10.177.73.61] (unknown [10.177.73.61]) by mail-irva-13.broadcom.com (Postfix) with ESMTP id 6000A74D06 for ; Wed, 29 Jun 2011 05:21:02 -0700 (PDT) Message-ID: <4E0B18AD.3040100@broadcom.com> Date: Wed, 29 Jun 2011 12:21:00 -0000 From: "Andrew Burgess" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: "gdb-patches@sourceware.org" Subject: [PATCH] Check skip_cplus_tests for gdb.python/py-template.exp Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-06/txt/msg00442.txt.bz2 The test gdb.python/py-template.exp compiles a c++ test, if feels like we shouldn't be attempting this if the skip_cplus_test function returns true. The patch is below, OK to apply? As this seems fairly obvious I'll apply in a few days unless someone asks me not too. Cheers, Andrew gdb/testsuite/ChangeLog 2011-06-29 Andrew Burgess * gdb.python/py-template.exp: Don't run this test if the target does not support c++ tests. diff --git a/gdb/testsuite/gdb.python/py-template.exp b/gdb/testsuite/gdb.python/py-template.exp index d22e4d1..9656831 100644 --- a/gdb/testsuite/gdb.python/py-template.exp +++ b/gdb/testsuite/gdb.python/py-template.exp @@ -20,6 +20,8 @@ if $tracelevel then { strace $tracelevel } +if { [skip_cplus_tests] } { continue } + set testfile "py-template" set srcfile ${testfile}.cc set binfile ${objdir}/${subdir}/${testfile}