From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on NULL rl_prompt
Date: Tue, 30 Mar 2010 17:13:00 -0000 [thread overview]
Message-ID: <m3fx3hwx5b.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20100330170457.GA10938@host0.dyn.jankratochvil.net> (Jan Kratochvil's message of "Tue, 30 Mar 2010 19:04:57 +0200")
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Pedro> But, how did rl_prompt end up NULL in the first place?
Jan> I do not know.
Yeah, it is not great that we don't know how to reproduce it.
But, given that part of the readline contract is that rl_prompt==NULL is
a valid state, I think tui_prep_terminal ought to cope with that as
well. Maybe there is also some other bug somewhere else, but that
doesn't affect the correctness of this particular patch.
Pedro> That's what I meant by masking out a bug.
Jan> An existing bug a user cannot notice is ... no longer a bug, isn't it?
I'm sympathetic to this, but I would assume that however the user got
gdb into this weird state could also hypothetically reveal other latent
bugs. I still think your fix is ok, but without a reproducer we can't
really be sure we've fixed the problem.
Tom
next prev parent reply other threads:[~2010-03-30 17:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 23:40 Jan Kratochvil
2010-03-30 15:57 ` Tom Tromey
2010-03-30 16:12 ` Pedro Alves
2010-03-30 16:23 ` Tom Tromey
2010-03-30 16:41 ` Pedro Alves
2010-03-30 17:05 ` Jan Kratochvil
2010-03-30 17:13 ` Tom Tromey [this message]
2010-03-30 17:25 ` Pedro Alves
2010-03-30 17:29 ` Jan Kratochvil
2010-03-30 17:55 ` Pedro Alves
2010-03-31 21:27 ` [cancel] " Jan Kratochvil
2010-03-30 17:31 ` Tom Tromey
2010-03-30 20:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fx3hwx5b.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox