From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix crash on NULL rl_prompt
Date: Tue, 30 Mar 2010 17:31:00 -0000 [thread overview]
Message-ID: <m38w99wwc7.fsf@fleche.redhat.com> (raw)
In-Reply-To: <201003301825.18754.pedro@codesourcery.com> (Pedro Alves's message of "Tue, 30 Mar 2010 18:25:18 +0100")
>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:
Pedro> But isn't `rl_prompt' always built from input feed to readline?
Yes.
Pedro> GDB always gives readline a non-NULL prompt, from what I've seen.
Pedro> Hence, I wouldn't be so fast in calling it correct, but I'm
Pedro> not going to spend more time on this.
I see it as defensive programming.
We can always un-approve it, if you would rather wait to see if a
reproducer is available.
Tom
next prev parent reply other threads:[~2010-03-30 17:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-29 23:40 Jan Kratochvil
2010-03-30 15:57 ` Tom Tromey
2010-03-30 16:12 ` Pedro Alves
2010-03-30 16:23 ` Tom Tromey
2010-03-30 16:41 ` Pedro Alves
2010-03-30 17:05 ` Jan Kratochvil
2010-03-30 17:13 ` Tom Tromey
2010-03-30 17:25 ` Pedro Alves
2010-03-30 17:29 ` Jan Kratochvil
2010-03-30 17:55 ` Pedro Alves
2010-03-31 21:27 ` [cancel] " Jan Kratochvil
2010-03-30 17:31 ` Tom Tromey [this message]
2010-03-30 20:50 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38w99wwc7.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox