Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: [cancel] Re: [patch] Fix crash on NULL rl_prompt
Date: Wed, 31 Mar 2010 21:27:00 -0000	[thread overview]
Message-ID: <20100331212206.GA13903@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <201003301855.08267.pedro@codesourcery.com>

On Tue, 30 Mar 2010 19:55:08 +0200, Pedro Alves wrote:
> On Tuesday 30 March 2010 18:30:48, Tom Tromey wrote:
> > We can always un-approve it, if you would rather wait to see if a
> > reproducer is available.
> 
> I'll leave it up to you to decide.  But if this goes in,
> perhaps a comment saying this is being defensive would be good.

Found the problem was most probably due to a Fedora patch posted here without
the FSF GDB acceptance intention:
	[gdb FYI-patch] callback-mode readline-6.0 regression
	http://sourceware.org/ml/gdb-patches/2009-11/msg00596.html

That patch is needed only with readline-6.0 and neither with 5.1 nor 6.1.
That patch accidentally did rl_set_prompt (NULL).

(FSF GDB should import readline-6.1 but that is offtopic in this thread.)

Therefore not going to check-in this patch.


Thanks,
Jan


  reply	other threads:[~2010-03-31 21:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-29 23:40 Jan Kratochvil
2010-03-30 15:57 ` Tom Tromey
2010-03-30 16:12   ` Pedro Alves
2010-03-30 16:23     ` Tom Tromey
2010-03-30 16:41       ` Pedro Alves
2010-03-30 17:05         ` Jan Kratochvil
2010-03-30 17:13           ` Tom Tromey
2010-03-30 17:25           ` Pedro Alves
2010-03-30 17:29             ` Jan Kratochvil
2010-03-30 17:55               ` Pedro Alves
2010-03-31 21:27                 ` Jan Kratochvil [this message]
2010-03-30 17:31             ` Tom Tromey
2010-03-30 20:50             ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100331212206.GA13903@host0.dyn.jankratochvil.net \
    --to=jan.kratochvil@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox